Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.3
    • Fix Version/s: 1.3
    • Component/s: None
    • Labels:
      None

      Description

      Add a contrib area for Solr and modify existing build.xml to build, package and distribute contrib projects also.

      1. SOLR-563.patch
        20 kB
        Shalin Shekhar Mangar

        Issue Links

          Activity

          Hide
          Shalin Shekhar Mangar added a comment -

          An initial attempt to modify the build process to include contrib projects also.

          • The common elements of build.xml that can be re-used by contrib build files are extracted out into a common-build.xml
          • The targets for clean, dist, package, javadoc have been modified to execute corresponding targets from contrib build files.
          • The dist-war target has been changed to include the contents of build/web when building the war file. This enables the contrib to add themselves into the Solr war file.

          The changes are modeled after Lucene's contrib builds. However, I have not created a contrib-build.xml which Lucene uses. As we have more contribs, we can do that.

          A few missing things are:

          • Javadocs for contribs are not included in the nightly builds
          • Clover integration has not been touched
          • Probably many more that I missed
          Show
          Shalin Shekhar Mangar added a comment - An initial attempt to modify the build process to include contrib projects also. The common elements of build.xml that can be re-used by contrib build files are extracted out into a common-build.xml The targets for clean, dist, package, javadoc have been modified to execute corresponding targets from contrib build files. The dist-war target has been changed to include the contents of build/web when building the war file. This enables the contrib to add themselves into the Solr war file. The changes are modeled after Lucene's contrib builds. However, I have not created a contrib-build.xml which Lucene uses. As we have more contribs, we can do that. A few missing things are: Javadocs for contribs are not included in the nightly builds Clover integration has not been touched Probably many more that I missed
          Hide
          Hoss Man added a comment -

          per comment on the mailing list

          Show
          Hoss Man added a comment - per comment on the mailing list
          Hide
          Otis Gospodnetic added a comment -

          Shalin, I think I saw you mentioning you'll be working on this soon. Should I wait for your changes then, or does it make sense to commit what you've got so far (haven't looked at the patch yet)? Ah, yes, I remember, you said you'd add Maven pom stuff. I'll wait.

          Show
          Otis Gospodnetic added a comment - Shalin, I think I saw you mentioning you'll be working on this soon. Should I wait for your changes then, or does it make sense to commit what you've got so far (haven't looked at the patch yet)? Ah, yes, I remember, you said you'd add Maven pom stuff. I'll wait.
          Hide
          Shalin Shekhar Mangar added a comment -

          Otis, we can work on the maven issue separately. I've tested the current patch both with and without the DataImportHandler contrib patches and it works fine. At the very least, it doesn't break any of the existing functionality. So, we should be ok to commit this.

          We can work on the maven issue separately as part of SOLR-586 once this gets committed.

          Show
          Shalin Shekhar Mangar added a comment - Otis, we can work on the maven issue separately. I've tested the current patch both with and without the DataImportHandler contrib patches and it works fine. At the very least, it doesn't break any of the existing functionality. So, we should be ok to commit this. We can work on the maven issue separately as part of SOLR-586 once this gets committed.
          Hide
          Otis Gospodnetic added a comment -

          Thanks!

          svn ci CHANGES.txt build.xml common-build.xml
          Sending CHANGES.txt
          Sending build.xml
          Adding common-build.xml
          Transmitting file data ...
          Committed revision 671021.

          Show
          Otis Gospodnetic added a comment - Thanks! svn ci CHANGES.txt build.xml common-build.xml Sending CHANGES.txt Sending build.xml Adding common-build.xml Transmitting file data ... Committed revision 671021.

            People

            • Assignee:
              Otis Gospodnetic
              Reporter:
              Shalin Shekhar Mangar
            • Votes:
              2 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development