Solr
  1. Solr
  2. SOLR-559

use Lucene updateDocument, deleteDocuments

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3
    • Component/s: None
    • Labels:
      None

      Description

      Use Lucene updateDocument and deleteDocuments calls for the update handler

      1. SOLR-559.patch
        13 kB
        Yonik Seeley

        Activity

        Yonik Seeley created issue -
        Hide
        Yonik Seeley added a comment -

        Attaching patch.
        Lucene's newer updateDocument and deleteDocuments have advantags over Solr's older implementation.

        • updates are atomic so a crash doesn't result in duplicates
        • deletes are applied on every new segment flush so they don't build up too much in memory
        • applying deletes doesn't force a writer close,reader open/close, writer open... and in addition to being more efficient, it allows a longer IndexWriter session, which results in a more compact index since segments in the same session can share the stored field docstore.
        Show
        Yonik Seeley added a comment - Attaching patch. Lucene's newer updateDocument and deleteDocuments have advantags over Solr's older implementation. updates are atomic so a crash doesn't result in duplicates deletes are applied on every new segment flush so they don't build up too much in memory applying deletes doesn't force a writer close,reader open/close, writer open... and in addition to being more efficient, it allows a longer IndexWriter session, which results in a more compact index since segments in the same session can share the stored field docstore.
        Yonik Seeley made changes -
        Field Original Value New Value
        Attachment SOLR-559.patch [ 12381391 ]
        Hide
        Yonik Seeley added a comment -

        I'll commit within the next day or so unless there are objections.

        Show
        Yonik Seeley added a comment - I'll commit within the next day or so unless there are objections.
        Hide
        Ryan McKinley added a comment -

        This seems like the right path to go down...

        Any advice on how to get SOLR-139 working once this path is in?

        Show
        Ryan McKinley added a comment - This seems like the right path to go down... Any advice on how to get SOLR-139 working once this path is in?
        Hide
        Mike Klaas added a comment -

        This patch should probably remove all references to "maxPendingDeletes", including in the example solrconfig.xml.

        Show
        Mike Klaas added a comment - This patch should probably remove all references to "maxPendingDeletes", including in the example solrconfig.xml.
        Hide
        Yonik Seeley added a comment -

        committed (and removed maxPendingDeletes from example schema.xml)

        Show
        Yonik Seeley added a comment - committed (and removed maxPendingDeletes from example schema.xml)
        Yonik Seeley made changes -
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Resolved [ 5 ]
        Yonik Seeley made changes -
        Fix Version/s 1.3 [ 12312486 ]
        Assignee Yonik Seeley [ yseeley@gmail.com ]
        Hide
        Yonik Seeley added a comment -

        Any advice on how to get SOLR-139 working once this path is in?

        Either add back tracking of the pending set, or perhaps just take the previous version of DUH2 and rename it to something else and use that in the solrconfig.xml

        Longer term, I hope Lucene comes up with a solution to this.

        Show
        Yonik Seeley added a comment - Any advice on how to get SOLR-139 working once this path is in? Either add back tracking of the pending set, or perhaps just take the previous version of DUH2 and rename it to something else and use that in the solrconfig.xml Longer term, I hope Lucene comes up with a solution to this.
        Uwe Schindler made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        6d 7h 11m 1 Yonik Seeley 10/May/08 22:29
        Resolved Resolved Closed Closed
        1825d 13h 9m 1 Uwe Schindler 10/May/13 11:39

          People

          • Assignee:
            Yonik Seeley
            Reporter:
            Yonik Seeley
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development