Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-5576

ZkController.java registerAllCoresAsDown multiple cores logic

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.6.1, 4.7, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      The behaviour we saw was that considerable time elapsed between
      different cores within the same solr instance publishing themselves as down.

      Separately it appears from the code that some cores would not be published as down if another core returns from the function early because it will be its
      shard leader (return vs. continue in for loop).

      1. SOLR-5576.patch
        4 kB
        Christine Poerschke

        Activity

        Hide
        cpoerschke Christine Poerschke added a comment -

        Attaching patch to separate publish-as-down and waitForLeaderToSeeDownState into separate for loops. Also replacing return with continue when waitForLeaderToSeeDownState call can be skipped.

        Show
        cpoerschke Christine Poerschke added a comment - Attaching patch to separate publish-as-down and waitForLeaderToSeeDownState into separate for loops. Also replacing return with continue when waitForLeaderToSeeDownState call can be skipped.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1553178 from Mark Miller in branch 'dev/trunk'
        [ https://svn.apache.org/r1553178 ]

        SOLR-5576: Improve concurrency when registering and waiting for all SolrCore's to register a DOWN state.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1553178 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1553178 ] SOLR-5576 : Improve concurrency when registering and waiting for all SolrCore's to register a DOWN state.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1553179 from Mark Miller in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1553179 ]

        SOLR-5576: Improve concurrency when registering and waiting for all SolrCore's to register a DOWN state.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1553179 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1553179 ] SOLR-5576 : Improve concurrency when registering and waiting for all SolrCore's to register a DOWN state.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1553954 from Mark Miller in branch 'dev/branches/lucene_solr_4_6'
        [ https://svn.apache.org/r1553954 ]

        SOLR-5576: Improve concurrency when registering and waiting for all SolrCore's to register a DOWN state.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1553954 from Mark Miller in branch 'dev/branches/lucene_solr_4_6' [ https://svn.apache.org/r1553954 ] SOLR-5576 : Improve concurrency when registering and waiting for all SolrCore's to register a DOWN state.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1553956 from Mark Miller in branch 'dev/trunk'
        [ https://svn.apache.org/r1553956 ]

        SOLR-5576: Move CHANGES to 4.6.1

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1553956 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1553956 ] SOLR-5576 : Move CHANGES to 4.6.1
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1553958 from Mark Miller in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1553958 ]

        SOLR-5576: Move CHANGES to 4.6.1

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1553958 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1553958 ] SOLR-5576 : Move CHANGES to 4.6.1
        Hide
        markrmiller@gmail.com Mark Miller added a comment -

        Thanks Christine!

        Show
        markrmiller@gmail.com Mark Miller added a comment - Thanks Christine!

          People

          • Assignee:
            markrmiller@gmail.com Mark Miller
            Reporter:
            cpoerschke Christine Poerschke
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development