Solr
  1. Solr
  2. SOLR-5576

ZkController.java registerAllCoresAsDown multiple cores logic

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.6.1, 4.7, Trunk
    • Component/s: None
    • Labels:
      None

      Description

      The behaviour we saw was that considerable time elapsed between
      different cores within the same solr instance publishing themselves as down.

      Separately it appears from the code that some cores would not be published as down if another core returns from the function early because it will be its
      shard leader (return vs. continue in for loop).

      1. SOLR-5576.patch
        4 kB
        Christine Poerschke

        Activity

        Christine Poerschke created issue -
        Hide
        Christine Poerschke added a comment -

        Attaching patch to separate publish-as-down and waitForLeaderToSeeDownState into separate for loops. Also replacing return with continue when waitForLeaderToSeeDownState call can be skipped.

        Show
        Christine Poerschke added a comment - Attaching patch to separate publish-as-down and waitForLeaderToSeeDownState into separate for loops. Also replacing return with continue when waitForLeaderToSeeDownState call can be skipped.
        Christine Poerschke made changes -
        Field Original Value New Value
        Attachment SOLR-5576.patch [ 12620231 ]
        Mark Miller made changes -
        Assignee Mark Miller [ markrmiller@gmail.com ]
        Mark Miller made changes -
        Issue Type Bug [ 1 ] Improvement [ 4 ]
        Fix Version/s 5.0 [ 12321664 ]
        Fix Version/s 4.7 [ 12325573 ]
        Fix Version/s 4.6.1 [ 12325762 ]
        Hide
        ASF subversion and git services added a comment -

        Commit 1553178 from Mark Miller in branch 'dev/trunk'
        [ https://svn.apache.org/r1553178 ]

        SOLR-5576: Improve concurrency when registering and waiting for all SolrCore's to register a DOWN state.

        Show
        ASF subversion and git services added a comment - Commit 1553178 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1553178 ] SOLR-5576 : Improve concurrency when registering and waiting for all SolrCore's to register a DOWN state.
        Hide
        ASF subversion and git services added a comment -

        Commit 1553179 from Mark Miller in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1553179 ]

        SOLR-5576: Improve concurrency when registering and waiting for all SolrCore's to register a DOWN state.

        Show
        ASF subversion and git services added a comment - Commit 1553179 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1553179 ] SOLR-5576 : Improve concurrency when registering and waiting for all SolrCore's to register a DOWN state.
        Hide
        ASF subversion and git services added a comment -

        Commit 1553954 from Mark Miller in branch 'dev/branches/lucene_solr_4_6'
        [ https://svn.apache.org/r1553954 ]

        SOLR-5576: Improve concurrency when registering and waiting for all SolrCore's to register a DOWN state.

        Show
        ASF subversion and git services added a comment - Commit 1553954 from Mark Miller in branch 'dev/branches/lucene_solr_4_6' [ https://svn.apache.org/r1553954 ] SOLR-5576 : Improve concurrency when registering and waiting for all SolrCore's to register a DOWN state.
        Hide
        ASF subversion and git services added a comment -

        Commit 1553956 from Mark Miller in branch 'dev/trunk'
        [ https://svn.apache.org/r1553956 ]

        SOLR-5576: Move CHANGES to 4.6.1

        Show
        ASF subversion and git services added a comment - Commit 1553956 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1553956 ] SOLR-5576 : Move CHANGES to 4.6.1
        Hide
        ASF subversion and git services added a comment -

        Commit 1553958 from Mark Miller in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1553958 ]

        SOLR-5576: Move CHANGES to 4.6.1

        Show
        ASF subversion and git services added a comment - Commit 1553958 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1553958 ] SOLR-5576 : Move CHANGES to 4.6.1
        Hide
        Mark Miller added a comment -

        Thanks Christine!

        Show
        Mark Miller added a comment - Thanks Christine!
        Mark Miller made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        David Smiley made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        13d 2h 55m 1 Mark Miller 05/Jan/14 21:00
        Resolved Resolved Closed Closed
        69d 16h 3m 1 David Smiley 16/Mar/14 13:04

          People

          • Assignee:
            Mark Miller
            Reporter:
            Christine Poerschke
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development