Solr
  1. Solr
  2. SOLR-5567

ZkController getHostAddress duplicates url prefix

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.6
    • Fix Version/s: 4.7, 6.0
    • Component/s: SolrCloud
    • Labels:
      None

      Description

      The ZkController getHostAddress method will return a URL with duplicated url prefix if given an input string already including a url prefix.

      e.g. given the input "http://127.0.0.1", it will return "http://http://127.0.0.1"

      1. SOLR-5567.patch
        3 kB
        Shalin Shekhar Mangar
      2. SOLR-5567.patch
        0.7 kB
        Shalin Shekhar Mangar

        Issue Links

          Activity

          Hide
          Shalin Shekhar Mangar added a comment -

          Trivial patch

          Show
          Shalin Shekhar Mangar added a comment - Trivial patch
          Hide
          Mark Miller added a comment -

          We should add a little test too.

          Show
          Mark Miller added a comment - We should add a little test too.
          Hide
          Mark Miller added a comment -

          Note: Alexey spotted this and provided a fix in SOLR-3854 as well. It was never addressed.

          Show
          Mark Miller added a comment - Note: Alexey spotted this and provided a fix in SOLR-3854 as well. It was never addressed.
          Hide
          Shalin Shekhar Mangar added a comment -

          Patch with test.

          Show
          Shalin Shekhar Mangar added a comment - Patch with test.
          Hide
          ASF subversion and git services added a comment -

          Commit 1553491 from shalin@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1553491 ]

          SOLR-5567: ZkController getHostAddress duplicates url prefix

          Show
          ASF subversion and git services added a comment - Commit 1553491 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1553491 ] SOLR-5567 : ZkController getHostAddress duplicates url prefix
          Hide
          ASF subversion and git services added a comment -

          Commit 1553498 from shalin@apache.org in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1553498 ]

          SOLR-5567: ZkController getHostAddress duplicates url prefix

          Show
          ASF subversion and git services added a comment - Commit 1553498 from shalin@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1553498 ] SOLR-5567 : ZkController getHostAddress duplicates url prefix
          Hide
          Shalin Shekhar Mangar added a comment -

          This is fixed.

          Thanks Mark for pointing out SOLR-3854. I have added an attribution to Alexey.

          Thanks Kyle!

          Show
          Shalin Shekhar Mangar added a comment - This is fixed. Thanks Mark for pointing out SOLR-3854 . I have added an attribution to Alexey. Thanks Kyle!

            People

            • Assignee:
              Shalin Shekhar Mangar
              Reporter:
              Kyle Halliday
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 5m
                5m
                Remaining:
                Remaining Estimate - 5m
                5m
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development