Solr
  1. Solr
  2. SOLR-5548

Give DistributedSearchTestCase / JettySolrRunner the ability to specify extra filters

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.7, 6.0
    • Fix Version/s: 4.7, 6.0
    • Component/s: Tests
    • Labels:
      None

      Description

      I want to write a test case based around my own custom request handler using AbstractFullDistribZkTestBase. The issue I'm running into is that for my request handler to work properly, it requires a custom filter to set some properties on the HttpServletRequest.

      AbstractFullDistribZkTestBase allows one to specify extra servlets, but not extra filters on the root servlet. It would be useful to allow the user to specify extra filters that run before the SolrDispatchFilter.

      1. SOLR-5548.patch
        7 kB
        Gregory Chanan

        Activity

        Hide
        Gregory Chanan added a comment -

        Here's a patch that implements this. I used it to successfully write a test case as I described above.

        Show
        Gregory Chanan added a comment - Here's a patch that implements this. I used it to successfully write a test case as I described above.
        Hide
        ASF subversion and git services added a comment -

        Commit 1550508 from Mark Miller in branch 'dev/trunk'
        [ https://svn.apache.org/r1550508 ]

        SOLR-5548: Give DistributedSearchTestCase / JettySolrRunner the ability to specify extra filters.

        Show
        ASF subversion and git services added a comment - Commit 1550508 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1550508 ] SOLR-5548 : Give DistributedSearchTestCase / JettySolrRunner the ability to specify extra filters.
        Hide
        ASF subversion and git services added a comment -

        Commit 1550514 from Mark Miller in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1550514 ]

        SOLR-5548: Give DistributedSearchTestCase / JettySolrRunner the ability to specify extra filters.

        Show
        ASF subversion and git services added a comment - Commit 1550514 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1550514 ] SOLR-5548 : Give DistributedSearchTestCase / JettySolrRunner the ability to specify extra filters.
        Hide
        Mark Miller added a comment -

        Thanks Greg!

        Show
        Mark Miller added a comment - Thanks Greg!

          People

          • Assignee:
            Mark Miller
            Reporter:
            Gregory Chanan
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development