Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.7, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      This works well in the general case (esp with huge numbers of unique values), but the SortedSetDocValuesAccumulator in lucene/facets does the algorithm better for typical cases (smaller number of unique values wrt the size of the document set).

      In this case, it collects directly with per-segment local ords, then remaps as a second step. So this is a lot less remapping.

      Its too bad the code is separate at the moment, for now lets steal the heuristic.

        Activity

        Hide
        Robert Muir added a comment -

        patch.

        also fixes a few unrelated bugs that got in the way:

        • BitDocSet's DISI's cost() method doesnt prorate for the size of the segment relative to the whole thing (since the bitset is unfortunately top-level)
        • If you hit an exception during faceting, the stacktrace is completely lost because of a bug in SimpleFacets (from SOLR-2548)
        Show
        Robert Muir added a comment - patch. also fixes a few unrelated bugs that got in the way: BitDocSet's DISI's cost() method doesnt prorate for the size of the segment relative to the whole thing (since the bitset is unfortunately top-level) If you hit an exception during faceting, the stacktrace is completely lost because of a bug in SimpleFacets (from SOLR-2548 )
        Hide
        ASF subversion and git services added a comment -

        Commit 1546675 from Robert Muir in branch 'dev/trunk'
        [ https://svn.apache.org/r1546675 ]

        SOLR-5512: Optimize DocValuesFacets

        Show
        ASF subversion and git services added a comment - Commit 1546675 from Robert Muir in branch 'dev/trunk' [ https://svn.apache.org/r1546675 ] SOLR-5512 : Optimize DocValuesFacets
        Hide
        ASF subversion and git services added a comment -

        Commit 1546676 from Robert Muir in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1546676 ]

        SOLR-5512: Optimize DocValuesFacets

        Show
        ASF subversion and git services added a comment - Commit 1546676 from Robert Muir in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1546676 ] SOLR-5512 : Optimize DocValuesFacets

          People

          • Assignee:
            Unassigned
            Reporter:
            Robert Muir
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development