[SOLR-5510] genericCoreNodeNames="${genericCoreNodeNames:false}" and old style solr.xml fails to create collection

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Invalid
• Affects Version/s: 4.6
• Fix Version/s: 4.6.1
• Assignee: Noble Paul
• Reporter: Noble Paul
• Created: 27/Nov/13 18:56
• Updated: 24/Feb/14 16:00
• Resolved: 24/Feb/14 16:00

Description

See this for some more details https://gist.github.com/serba/1fe113e78ae7e01a4f58

This is a regression caused by SOLR-5311

There are two reasons why a core does not have a reference in clusterstate

1. It is starting up for the first time (core creation)
2. Somebody invoked a DELETEREPLICA when the node itself was down

we neded to differentiate these two because for 1) the registration should succeed and for #2 the registration should fail

The only way to do that was to check for the presence of the attribute coreNodeName in the core.properties. In case #1 it would be absent and in case#2 it would be present

but when genericCoreNodeNames="${genericCoreNodeNames:false}"

ZkController#getCoreNodeName(getCoreNodeName) behaves similarly for both the cases and hence the failure