Solr
  1. Solr
  2. SOLR-5496

We should share an http connection manager across most non search httpclients and ensure all http connection managers get shutdown.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.6.1, 4.7, 6.0
    • Component/s: None
    • Labels:
      None
    1. SOLR-5496.patch
      33 kB
      Mark Miller

      Issue Links

        Activity

        Hide
        Mark Miller added a comment -

        I think I've got this mostly addressed for a first pass. Going to finish an item or too later and put up a patch.

        Show
        Mark Miller added a comment - I think I've got this mostly addressed for a first pass. Going to finish an item or too later and put up a patch.
        Hide
        Mark Miller added a comment -

        I've cleaned this up quite a bit.

        Show
        Mark Miller added a comment - I've cleaned this up quite a bit.
        Hide
        Ryan Ernst added a comment -

        Did you mean to make similar changes in HttpShardHandlerFactory as well? I see an import of the pooling client in there, but no other changes?

        Show
        Ryan Ernst added a comment - Did you mean to make similar changes in HttpShardHandlerFactory as well? I see an import of the pooling client in there, but no other changes?
        Hide
        ASF subversion and git services added a comment -

        Commit 1544899 from Mark Miller in branch 'dev/trunk'
        [ https://svn.apache.org/r1544899 ]

        SOLR-5496: We should share an http connection manager across non search HttpClients and ensure all http connection managers get shutdown.

        Show
        ASF subversion and git services added a comment - Commit 1544899 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1544899 ] SOLR-5496 : We should share an http connection manager across non search HttpClients and ensure all http connection managers get shutdown.
        Hide
        ASF subversion and git services added a comment -

        Commit 1544900 from Mark Miller in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1544900 ]

        SOLR-5496: We should share an http connection manager across non search HttpClients and ensure all http connection managers get shutdown.

        Show
        ASF subversion and git services added a comment - Commit 1544900 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1544900 ] SOLR-5496 : We should share an http connection manager across non search HttpClients and ensure all http connection managers get shutdown.
        Hide
        Mark Miller added a comment - - edited

        Did you mean to make similar changes in HttpShardHandlerFactory as well? I see an import of the pooling client in there, but no other changes?

        Do you have something in mind? It seemed it was fairly well behaved - eg one poolingconectionmanager and one http client.

        I figure it should be a separate http client from update since you can do different timeouts.

        I'm certainly open to sharing the connection manager across both ...

        I just wanted to get jenkins take on these changes, but ready to do some iteration if you have some thoughts.

        Show
        Mark Miller added a comment - - edited Did you mean to make similar changes in HttpShardHandlerFactory as well? I see an import of the pooling client in there, but no other changes? Do you have something in mind? It seemed it was fairly well behaved - eg one poolingconectionmanager and one http client. I figure it should be a separate http client from update since you can do different timeouts. I'm certainly open to sharing the connection manager across both ... I just wanted to get jenkins take on these changes, but ready to do some iteration if you have some thoughts.
        Hide
        Ryan Ernst added a comment -

        I only meant that the patch contain a single additional import that appeared to be unused in that file?

        Index: solr/core/src/java/org/apache/solr/handler/component/HttpShardHandlerFactory.java
        ===================================================================
        --- solr/core/src/java/org/apache/solr/handler/component/HttpShardHandlerFactory.java	(revision 1544843)
        +++ solr/core/src/java/org/apache/solr/handler/component/HttpShardHandlerFactory.java	(working copy)
        @@ -30,6 +30,7 @@
         import java.util.concurrent.TimeUnit;
         
         import org.apache.http.client.HttpClient;
        +import org.apache.http.impl.conn.PoolingClientConnectionManager;
         import org.apache.solr.client.solrj.SolrServerException;
         import org.apache.solr.client.solrj.impl.HttpClientUtil;
         import org.apache.solr.client.solrj.impl.LBHttpSolrServer;
        
        Show
        Ryan Ernst added a comment - I only meant that the patch contain a single additional import that appeared to be unused in that file? Index: solr/core/src/java/org/apache/solr/handler/component/HttpShardHandlerFactory.java =================================================================== --- solr/core/src/java/org/apache/solr/handler/component/HttpShardHandlerFactory.java (revision 1544843) +++ solr/core/src/java/org/apache/solr/handler/component/HttpShardHandlerFactory.java (working copy) @@ -30,6 +30,7 @@ import java.util.concurrent.TimeUnit; import org.apache.http.client.HttpClient; + import org.apache.http.impl.conn.PoolingClientConnectionManager; import org.apache.solr.client.solrj.SolrServerException; import org.apache.solr.client.solrj.impl.HttpClientUtil; import org.apache.solr.client.solrj.impl.LBHttpSolrServer;
        Hide
        Mark Miller added a comment -

        Oh, that's just because I was playing around with sharing the connection manager. I cleaned that up before I committed the patch.

        Show
        Mark Miller added a comment - Oh, that's just because I was playing around with sharing the connection manager. I cleaned that up before I committed the patch.
        Hide
        ASF subversion and git services added a comment -

        Commit 1553984 from Mark Miller in branch 'dev/branches/lucene_solr_4_6'
        [ https://svn.apache.org/r1553984 ]

        SOLR-5496: We should share an http connection manager across non search HttpClients and ensure all http connection managers get shutdown.

        Show
        ASF subversion and git services added a comment - Commit 1553984 from Mark Miller in branch 'dev/branches/lucene_solr_4_6' [ https://svn.apache.org/r1553984 ] SOLR-5496 : We should share an http connection manager across non search HttpClients and ensure all http connection managers get shutdown.
        Hide
        ASF subversion and git services added a comment -

        Commit 1553985 from Mark Miller in branch 'dev/trunk'
        [ https://svn.apache.org/r1553985 ]

        SOLR-5496: Move CHANGES to 4.6.1

        Show
        ASF subversion and git services added a comment - Commit 1553985 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1553985 ] SOLR-5496 : Move CHANGES to 4.6.1
        Hide
        ASF subversion and git services added a comment -

        Commit 1553986 from Mark Miller in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1553986 ]

        SOLR-5496: Move CHANGES to 4.6.1

        Show
        ASF subversion and git services added a comment - Commit 1553986 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1553986 ] SOLR-5496 : Move CHANGES to 4.6.1

          People

          • Assignee:
            Mark Miller
            Reporter:
            Mark Miller
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development