Solr
  1. Solr
  2. SOLR-5452

Do not attempt to proxy internal update requests

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.6, 5.0
    • Component/s: SolrCloud
    • Labels:
      None
    1. SOLR-5452.patch
      11 kB
      Mark Miller

      Issue Links

        Activity

        Mark Miller created issue -
        Hide
        Mark Miller added a comment -

        I believe this is from after 4.5.

        Show
        Mark Miller added a comment - I believe this is from after 4.5.
        Hide
        Mark Miller added a comment -

        Looks like the proxy requests are involved in this - somehow a core is not being found when the leader sends some updates to a replica - and so the request is proxied back to the leader...

        What is odd is why the leader would be sending updates to a node and not be able to find the solrcore...

        Show
        Mark Miller added a comment - Looks like the proxy requests are involved in this - somehow a core is not being found when the leader sends some updates to a replica - and so the request is proxied back to the leader... What is odd is why the leader would be sending updates to a node and not be able to find the solrcore...
        Mark Miller made changes -
        Field Original Value New Value
        Priority Critical [ 2 ] Major [ 3 ]
        Hide
        Mark Miller added a comment -

        We probably should not attempt to proxy any requests that have the from leader param.

        Show
        Mark Miller added a comment - We probably should not attempt to proxy any requests that have the from leader param.
        Mark Miller made changes -
        Attachment SOLR-5452.patch [ 12614392 ]
        Hide
        ASF subversion and git services added a comment -

        Commit 1543037 from Mark Miller in branch 'dev/trunk'
        [ https://svn.apache.org/r1543037 ]

        SOLR-5452: Do not attempt to proxy internal update requests.

        Show
        ASF subversion and git services added a comment - Commit 1543037 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1543037 ] SOLR-5452 : Do not attempt to proxy internal update requests.
        Hide
        ASF subversion and git services added a comment -

        Commit 1543038 from Mark Miller in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1543038 ]

        SOLR-5452: Do not attempt to proxy internal update requests.

        Show
        ASF subversion and git services added a comment - Commit 1543038 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1543038 ] SOLR-5452 : Do not attempt to proxy internal update requests.
        Hide
        Mark Miller added a comment -

        Somehow this is causing some jenkins fails that I didn't see locally - one that I looked at looked like it was proxying a commit and failed with a non content stream found exception.

        Odd - the main change here would be simply that we access the query params before proxying the request.

        Show
        Mark Miller added a comment - Somehow this is causing some jenkins fails that I didn't see locally - one that I looked at looked like it was proxying a commit and failed with a non content stream found exception. Odd - the main change here would be simply that we access the query params before proxying the request.
        Mark Miller made changes -
        Fix Version/s 4.7 [ 12325573 ]
        Fix Version/s 4.6 [ 12325000 ]
        Hide
        Mark Miller added a comment -

        Fail in another test is the same thing - proxying a pure commit and getting a content stream not found exception.

        Show
        Mark Miller added a comment - Fail in another test is the same thing - proxying a pure commit and getting a content stream not found exception.
        Hide
        Mark Miller added a comment -

        This might be SOLR-5461 and somehow it was hidden before...

        Show
        Mark Miller added a comment - This might be SOLR-5461 and somehow it was hidden before...
        Hide
        Mark Miller added a comment -

        Okay, looks like getting the params does more than I'd like...perhaps we should just look in the query string...

        Forbidden method invocation: javax.servlet.ServletRequest#getParameterMap() [Servlet API method is parsing request parameters without using the correct encoding if no extra configuration is given in the servlet container]
        
        Show
        Mark Miller added a comment - Okay, looks like getting the params does more than I'd like...perhaps we should just look in the query string... Forbidden method invocation: javax.servlet.ServletRequest#getParameterMap() [Servlet API method is parsing request parameters without using the correct encoding if no extra configuration is given in the servlet container]
        Hide
        ASF subversion and git services added a comment -

        Commit 1543097 from Mark Miller in branch 'dev/trunk'
        [ https://svn.apache.org/r1543097 ]

        SOLR-5452: Parse params correctly.

        Show
        ASF subversion and git services added a comment - Commit 1543097 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1543097 ] SOLR-5452 : Parse params correctly.
        Hide
        ASF subversion and git services added a comment -

        Commit 1543098 from Mark Miller in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1543098 ]

        SOLR-5452: Parse params correctly.

        Show
        ASF subversion and git services added a comment - Commit 1543098 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1543098 ] SOLR-5452 : Parse params correctly.
        Hide
        ASF subversion and git services added a comment -

        Commit 1543108 from Mark Miller in branch 'dev/trunk'
        [ https://svn.apache.org/r1543108 ]

        SOLR-5452: Back this out for a bit

        Show
        ASF subversion and git services added a comment - Commit 1543108 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1543108 ] SOLR-5452 : Back this out for a bit
        Hide
        ASF subversion and git services added a comment -

        Commit 1543109 from Mark Miller in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1543109 ]

        SOLR-5452: Back this out for a bit

        Show
        ASF subversion and git services added a comment - Commit 1543109 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1543109 ] SOLR-5452 : Back this out for a bit
        Hide
        Mark Miller added a comment -

        I was running 4.6 branch local tests - doh.

        It seems we cannot parse posted params before we proxy the request or the proxied request has no content. We also can't necessarily count on query string params because the solrj client kind of determines that.

        Need to come up with something else...

        Show
        Mark Miller added a comment - I was running 4.6 branch local tests - doh. It seems we cannot parse posted params before we proxy the request or the proxied request has no content. We also can't necessarily count on query string params because the solrj client kind of determines that. Need to come up with something else...
        Hide
        Mark Miller added a comment -

        Well, I have an alternate approach that works.

        This was actually a little rats nest though - this proxying of internal requests was hiding some nasty issues from the tests!

        Show
        Mark Miller added a comment - Well, I have an alternate approach that works. This was actually a little rats nest though - this proxying of internal requests was hiding some nasty issues from the tests!
        Hide
        ASF subversion and git services added a comment -

        Commit 1543299 from Mark Miller in branch 'dev/trunk'
        [ https://svn.apache.org/r1543299 ]

        SOLR-5465: SolrCmdDistributor retry logic has a concurrency race bug.
        SOLR-5464: ConcurrentSolrServer does not stream pure delete by id requests.
        SOLR-5452: Do not attempt to proxy internal update requests.

        Show
        ASF subversion and git services added a comment - Commit 1543299 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1543299 ] SOLR-5465 : SolrCmdDistributor retry logic has a concurrency race bug. SOLR-5464 : ConcurrentSolrServer does not stream pure delete by id requests. SOLR-5452 : Do not attempt to proxy internal update requests.
        Hide
        ASF subversion and git services added a comment -

        Commit 1543300 from Mark Miller in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1543300 ]

        SOLR-5465: SolrCmdDistributor retry logic has a concurrency race bug.
        SOLR-5464: ConcurrentSolrServer does not stream pure delete by id requests.
        SOLR-5452: Do not attempt to proxy internal update requests.

        Show
        ASF subversion and git services added a comment - Commit 1543300 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1543300 ] SOLR-5465 : SolrCmdDistributor retry logic has a concurrency race bug. SOLR-5464 : ConcurrentSolrServer does not stream pure delete by id requests. SOLR-5452 : Do not attempt to proxy internal update requests.
        Hide
        ASF subversion and git services added a comment -

        Commit 1543301 from Mark Miller in branch 'dev/branches/lucene_solr_4_6'
        [ https://svn.apache.org/r1543301 ]

        SOLR-5464: Add option to ConcurrentSolrServer to stream pure delete requests.
        SOLR-5465: SolrCmdDistributor retry logic has a concurrency race bug.
        SOLR-5452: Do not attempt to proxy internal update requests.

        Show
        ASF subversion and git services added a comment - Commit 1543301 from Mark Miller in branch 'dev/branches/lucene_solr_4_6' [ https://svn.apache.org/r1543301 ] SOLR-5464 : Add option to ConcurrentSolrServer to stream pure delete requests. SOLR-5465 : SolrCmdDistributor retry logic has a concurrency race bug. SOLR-5452 : Do not attempt to proxy internal update requests.
        Mark Miller made changes -
        Link This issue is related to SOLR-5464 [ SOLR-5464 ]
        Mark Miller made changes -
        Summary DistributedUpdateProcessor can somehow think it is both the leader and replica to send updates to according to unit tests. Do not attempt to proxy internal update requests
        Fix Version/s 4.6 [ 12325000 ]
        Fix Version/s 4.7 [ 12325573 ]
        Hide
        ASF subversion and git services added a comment -

        Commit 1543450 from Mark Miller in branch 'dev/trunk'
        [ https://svn.apache.org/r1543450 ]

        SOLR-5464,SOLR-5465,SOLR-5452: Fix CHANGES entries - move to 4.6

        Show
        ASF subversion and git services added a comment - Commit 1543450 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1543450 ] SOLR-5464 , SOLR-5465 , SOLR-5452 : Fix CHANGES entries - move to 4.6
        Hide
        ASF subversion and git services added a comment -

        Commit 1543452 from Mark Miller in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1543452 ]

        SOLR-5464,SOLR-5465,SOLR-5452: Fix CHANGES entries - move to 4.6

        Show
        ASF subversion and git services added a comment - Commit 1543452 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1543452 ] SOLR-5464 , SOLR-5465 , SOLR-5452 : Fix CHANGES entries - move to 4.6
        Mark Miller made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Mark Miller
            Reporter:
            Mark Miller
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development