Solr
  1. Solr
  2. SOLR-5446

Admin UI - Allow changing Schema and Config

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Implemented
    • Affects Version/s: None
    • Fix Version/s: 4.7, 6.0
    • Component/s: web gui
    • Labels:
      None

      Description

      As a follow up to SOLR-5287, this is the UI related part for implementing a file-viewer and the possibility to change files (like schema & config) via the UI.

      1. SOLR-5446.patch
        18 kB
        Stefan Matheis (steffkes)
      2. SOLR-5446.patch
        14 kB
        Stefan Matheis (steffkes)
      3. SOLR-5446.patch
        12 kB
        Stefan Matheis (steffkes)
      4. SOLR-5446.patch
        10 kB
        Stefan Matheis (steffkes)

        Issue Links

          Activity

          Hide
          Erick Erickson added a comment -

          Just checked in the code for trunk, 4x in another hour or so.

          There are some TBDs on this page we'll want to fill re: where this functionality is in the UI
          https://wiki.apache.org/solr/Editing%20configuration%20files%20in%20the%20admin%20UI

          Show
          Erick Erickson added a comment - Just checked in the code for trunk, 4x in another hour or so. There are some TBDs on this page we'll want to fill re: where this functionality is in the UI https://wiki.apache.org/solr/Editing%20configuration%20files%20in%20the%20admin%20UI
          Hide
          Stefan Matheis (steffkes) added a comment - - edited

          First shot, contains basic tree - will continue tomorrow, showing the current content of the selected file and sending modified content back. step after that would be to integrate fileupload.

          Show
          Stefan Matheis (steffkes) added a comment - - edited First shot, contains basic tree - will continue tomorrow, showing the current content of the selected file and sending modified content back. step after that would be to integrate fileupload.
          Hide
          Stefan Matheis (steffkes) added a comment -

          Next Version, including form to modify the selected file and button to save the changed file back on disk/to ZK

          Show
          Stefan Matheis (steffkes) added a comment - Next Version, including form to modify the selected file and button to save the changed file back on disk/to ZK
          Hide
          Erick Erickson added a comment -

          Man, I just downloaded our other patch!

          Anyway, it'll be a busy morning here but I should be able to take a look this afternoon.

          I'm geeked by this! I think it'll let people get started using Solr easier..

          Show
          Erick Erickson added a comment - Man, I just downloaded our other patch! Anyway, it'll be a busy morning here but I should be able to take a look this afternoon. I'm geeked by this! I think it'll let people get started using Solr easier..
          Hide
          Erick Erickson added a comment -

          Sweet! On a quick look, this looks near done!

          One thing that would be really cool is if xml files had syntax highlighting. Don't know how possible that is, if it's easy.... If it's not easy, let someone do that in the future .

          I know, "what have you done for me lately?"

          Thanks!

          Show
          Erick Erickson added a comment - Sweet! On a quick look, this looks near done! One thing that would be really cool is if xml files had syntax highlighting. Don't know how possible that is, if it's easy.... If it's not easy, let someone do that in the future . I know, "what have you done for me lately?" Thanks!
          Hide
          Stefan Matheis (steffkes) added a comment -

          based on the selected file, the tree is expanded until the correct directory is open.

          next steps: integrate file-upload and a bit error handling

          Show
          Stefan Matheis (steffkes) added a comment - based on the selected file, the tree is expanded until the correct directory is open. next steps: integrate file-upload and a bit error handling
          Hide
          Stefan Matheis (steffkes) added a comment -

          One thing that would be really cool is if xml files had syntax highlighting. Don't know how possible that is, if it's easy.... If it's not easy, let someone do that in the future .

          Hmm, since that's a normal <textarea> .. that's actually text-only, but i'll see what's possible there (:

          Show
          Stefan Matheis (steffkes) added a comment - One thing that would be really cool is if xml files had syntax highlighting. Don't know how possible that is, if it's easy.... If it's not easy, let someone do that in the future . Hmm, since that's a normal <textarea> .. that's actually text-only, but i'll see what's possible there (:
          Hide
          Stefan Matheis (steffkes) added a comment -

          Ready to go :> Needs testing, will do that tomorrow

          Erick Erickson any comments so far? will open another issue for the xml validation thing, so we can implement that afterwards

          Show
          Stefan Matheis (steffkes) added a comment - Ready to go :> Needs testing, will do that tomorrow Erick Erickson any comments so far? will open another issue for the xml validation thing, so we can implement that afterwards
          Hide
          Erick Erickson added a comment -

          Waaaaay cool! I especially like the "upload file" option.

          Three things come to mind:

          1> What about an "add new file" that would put a new file up to whatever directory is currently open? Maybe from the screen just before the file-edit screen? NOTE: This could very well be a follow-on JIRA.

          2> Rather than "upload file", maybe something like "Replace current file"? Just some indicator that this action will replace the currently open file. I managed to replace schema.xml with a patch file when I was testing...

          3> Maybe a "reload core/collection" button so you could make the changes "live"? Whether the button says core or collection could be dependent on whether we're in SolrCloud mode or not....

          Frankly, though, I don't care much if any of these suggestions is adopted immediately, they can always be follow-on JIRAs. Making this available in the UI is cool IMO!

          As soon as this is committed, I'll blast a message out to the Solr list to see what people think. I think this is one of those things that people will really like.

          Show
          Erick Erickson added a comment - Waaaaay cool! I especially like the "upload file" option. Three things come to mind: 1> What about an "add new file" that would put a new file up to whatever directory is currently open? Maybe from the screen just before the file-edit screen? NOTE: This could very well be a follow-on JIRA. 2> Rather than "upload file", maybe something like "Replace current file"? Just some indicator that this action will replace the currently open file. I managed to replace schema.xml with a patch file when I was testing... 3> Maybe a "reload core/collection" button so you could make the changes "live"? Whether the button says core or collection could be dependent on whether we're in SolrCloud mode or not.... Frankly, though, I don't care much if any of these suggestions is adopted immediately, they can always be follow-on JIRAs. Making this available in the UI is cool IMO! As soon as this is committed, I'll blast a message out to the Solr list to see what people think. I think this is one of those things that people will really like.
          Hide
          Erick Erickson added a comment -

          One other thought occurred to me. Does it make sense to remove the 'config' and 'schema' links on the left after you've selected the core? They seem unnecessary with this new capability.

          No big deal either way.

          Show
          Erick Erickson added a comment - One other thought occurred to me. Does it make sense to remove the 'config' and 'schema' links on the left after you've selected the core? They seem unnecessary with this new capability. No big deal either way.
          Hide
          ASF subversion and git services added a comment -

          Commit 1542720 from Stefan Matheis (steffkes) in branch 'dev/trunk'
          [ https://svn.apache.org/r1542720 ]

          SOLR-5446: Admin UI - Allow changing Schema and Config

          Show
          ASF subversion and git services added a comment - Commit 1542720 from Stefan Matheis (steffkes) in branch 'dev/trunk' [ https://svn.apache.org/r1542720 ] SOLR-5446 : Admin UI - Allow changing Schema and Config
          Hide
          ASF subversion and git services added a comment -

          Commit 1542721 from Stefan Matheis (steffkes) in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1542721 ]

          SOLR-5446: Admin UI - Allow changing Schema and Config (merge r1542720)

          Show
          ASF subversion and git services added a comment - Commit 1542721 from Stefan Matheis (steffkes) in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1542721 ] SOLR-5446 : Admin UI - Allow changing Schema and Config (merge r1542720)
          Hide
          Stefan Matheis (steffkes) added a comment -

          I've committed the current state (including the change, renaming the button for uploading a new file). All the other suggestions are tracked within new issues (already linked to that one).

          Erick Erickson removing the schema & config links is a nice idea, makes sense. perhaps it would be a nice to have, to say the file browser is showing files first (there we could have xml highlighting) with an option "edit this file" which switches over to a simple <textarea> where you could modify and save the file?

          Show
          Stefan Matheis (steffkes) added a comment - I've committed the current state (including the change, renaming the button for uploading a new file). All the other suggestions are tracked within new issues (already linked to that one). Erick Erickson removing the schema & config links is a nice idea, makes sense. perhaps it would be a nice to have, to say the file browser is showing files first (there we could have xml highlighting) with an option "edit this file" which switches over to a simple <textarea> where you could modify and save the file?
          Hide
          Erick Erickson added a comment -

          Stefan Matheis (steffkes): You're the UI person .

          Really, whatever you think best. I'm adding a bit of infrastructure to prevent editing the managed schema file...

          Show
          Erick Erickson added a comment - Stefan Matheis (steffkes) : You're the UI person . Really, whatever you think best. I'm adding a bit of infrastructure to prevent editing the managed schema file...

            People

            • Assignee:
              Stefan Matheis (steffkes)
              Reporter:
              Stefan Matheis (steffkes)
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development