Solr
  1. Solr
  2. SOLR-5441

Expose transaction log files number and their size via JMX

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.5
    • Fix Version/s: 4.7, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      It may be useful to have the number of transaction log files and their overall size exposed via JMX for UpdateHandler.

      1. SOLR-5441.patch
        2 kB
        Rafał Kuć
      2. SOLR-5441-null_fix.patch
        2 kB
        Rafał Kuć
      3. SOLR-5441-synchronized.patch
        2 kB
        Rafał Kuć

        Activity

        Hide
        Rafał Kuć added a comment -

        I'll provide patch later today.

        Show
        Rafał Kuć added a comment - I'll provide patch later today.
        Hide
        Rafał Kuć added a comment -

        Please look at the attached patch and see if this is the right approach and if anything should be modified.

        Show
        Rafał Kuć added a comment - Please look at the attached patch and see if this is the right approach and if anything should be modified.
        Hide
        Shalin Shekhar Mangar added a comment -

        Thanks Rafał. We need to put the iteration in a synchronized block.

        Show
        Shalin Shekhar Mangar added a comment - Thanks Rafał. We need to put the iteration in a synchronized block.
        Hide
        Rafał Kuć added a comment -

        Added sychronized on logs list in the UpdateLog class.

        Show
        Rafał Kuć added a comment - Added sychronized on logs list in the UpdateLog class.
        Hide
        ASF subversion and git services added a comment -

        Commit 1541999 from shalin@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1541999 ]

        SOLR-5441: Expose number of transaction log files and their size via JMX

        Show
        ASF subversion and git services added a comment - Commit 1541999 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1541999 ] SOLR-5441 : Expose number of transaction log files and their size via JMX
        Hide
        ASF subversion and git services added a comment -

        Commit 1542000 from shalin@apache.org in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1542000 ]

        SOLR-5441: Expose number of transaction log files and their size via JMX

        Show
        ASF subversion and git services added a comment - Commit 1542000 from shalin@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1542000 ] SOLR-5441 : Expose number of transaction log files and their size via JMX
        Hide
        Shalin Shekhar Mangar added a comment -

        Thanks Rafał!

        Show
        Shalin Shekhar Mangar added a comment - Thanks Rafał!
        Hide
        Tomás Fernández Löbbe added a comment -

        I think Jenkins failures are related to this commit: http://jenkins.thetaphi.de/job/Lucene-Solr-4.x-Linux/8218/

        Show
        Tomás Fernández Löbbe added a comment - I think Jenkins failures are related to this commit: http://jenkins.thetaphi.de/job/Lucene-Solr-4.x-Linux/8218/
        Hide
        Rafał Kuć added a comment -

        Patch fixing Jenkins issues after commit. Added null checking to DirectUpdateHandler2 and to TransactionLog.

        Show
        Rafał Kuć added a comment - Patch fixing Jenkins issues after commit. Added null checking to DirectUpdateHandler2 and to TransactionLog.
        Hide
        Erick Erickson added a comment -

        I think Shalin's asleep, I'll get this committed in a bit, supper's almost ready...

        Show
        Erick Erickson added a comment - I think Shalin's asleep, I'll get this committed in a bit, supper's almost ready...
        Hide
        ASF subversion and git services added a comment -

        Commit 1542142 from Erick Erickson in branch 'dev/trunk'
        [ https://svn.apache.org/r1542142 ]

        SOLR-5441: the null-pointer patch addition

        Show
        ASF subversion and git services added a comment - Commit 1542142 from Erick Erickson in branch 'dev/trunk' [ https://svn.apache.org/r1542142 ] SOLR-5441 : the null-pointer patch addition
        Hide
        ASF subversion and git services added a comment -

        Commit 1542150 from Erick Erickson in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1542150 ]

        SOLR-5441: the null-pointer patch addition

        Show
        ASF subversion and git services added a comment - Commit 1542150 from Erick Erickson in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1542150 ] SOLR-5441 : the null-pointer patch addition
        Hide
        Shalin Shekhar Mangar added a comment -

        Thanks for taking care of this Erick. I'll be more careful next time.

        Show
        Shalin Shekhar Mangar added a comment - Thanks for taking care of this Erick. I'll be more careful next time.
        Hide
        Erick Erickson added a comment -

        NP, we've all "been there, done that". The great thing about this
        community is that we all help each other out.

        Show
        Erick Erickson added a comment - NP, we've all "been there, done that". The great thing about this community is that we all help each other out.

          People

          • Assignee:
            Erick Erickson
            Reporter:
            Rafał Kuć
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development