[SOLR-539] Statistics variable atomicity in RequestHandlerBase

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.3
• Fix Version/s: 1.3
• Component/s: highlighter, search, spellchecker, update
• Assignee: Otis Gospodnetic
• Reporter: Sean Timm
• Created: 15/Apr/08 03:16
• Updated: 10/May/13 10:39
• Resolved: 22/May/08 02:13

Description

Writes are not atomic on longs unless they are volatile. At a minimum, numRequests, numErrors, and totalTime should be marked volatile. More correct, but higher overhead due to contention and synchronization would be to use AtomicLong.

There is a minor error in the calculation of avgRequestsPerSecond. The first operand of the denominator is cast to a float then has a long subtracted from it, in effect casting both longs to floats then performing the subtraction. It is better to do the subtraction as longs then cast to a float.