Solr
  1. Solr
  2. SOLR-5366

Too many close on transient core with unload command

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.4, 4.6
    • Fix Version/s: 4.6, Trunk
    • Component/s: multicore
    • Labels:

      Description

      Too many close on transient core with unload command, because already closed by transientcache

      To reproduce :
      set transientCacheSize=2 and start with no cores

      Create 3 cores :
      curl "http://ip:port/solr/admin/cores?action=CREATE&name=coreX&instanceDir=path_to_instanceDir_coreX&dataDir=path_to_dataDir_coreX&loadOnStartup=false&transient=true"

      Execute :
      curl "http://ip:port/solr/core1/select?q=:"
      curl "http://ip:port/solr/core2/select?q=:"
      curl "http://ip:port/solr/core3/select?q=:"

      curl "http://ip:port/solr/admin/cores?action=UNLOAD&core=core1"

      And in Solr logs :
      ERROR org.apache.solr.core.SolrCore – Too many close [count:-1] on org.apache.solr.core.SolrCore@20e5ace9. Please report this exception to solr-user@lucene.apache.org

      The patch in attachment is for svn solr branch_4X (revision number 1526418)

      1. SOLR-5366.patch
        0.9 kB
        olivier soyez
      2. SOLR-5366.patch
        5 kB
        Erick Erickson

        Activity

        Hide
        ASF subversion and git services added a comment -

        Commit 1539773 from Erick Erickson in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1539773 ]

        SOLR-5366: transient cores automatically unloaded when creating cores via admin API would be closed too many times

        Show
        ASF subversion and git services added a comment - Commit 1539773 from Erick Erickson in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1539773 ] SOLR-5366 : transient cores automatically unloaded when creating cores via admin API would be closed too many times
        Hide
        ASF subversion and git services added a comment -

        Commit 1539709 from Erick Erickson in branch 'dev/trunk'
        [ https://svn.apache.org/r1539709 ]

        SOLR-5366: transient cores automatically unloaded when creating cores via admin API would be closed too many times

        Show
        ASF subversion and git services added a comment - Commit 1539709 from Erick Erickson in branch 'dev/trunk' [ https://svn.apache.org/r1539709 ] SOLR-5366 : transient cores automatically unloaded when creating cores via admin API would be closed too many times
        Hide
        Erick Erickson added a comment -

        Building on Olivier's patch. I think there was a race condition possible (but unlikely) where the close could be pending on the transient core, so I changed the code a bit to avoid that.

        Thanks Olivier!

        Committing to trunk momentarily, 4x a in a bit.

        Show
        Erick Erickson added a comment - Building on Olivier's patch. I think there was a race condition possible (but unlikely) where the close could be pending on the transient core, so I changed the code a bit to avoid that. Thanks Olivier! Committing to trunk momentarily, 4x a in a bit.
        Hide
        Erick Erickson added a comment -

        Picking up so it stays on my radar, but I don't feel posessive!

        Show
        Erick Erickson added a comment - Picking up so it stays on my radar, but I don't feel posessive!

          People

          • Assignee:
            Erick Erickson
            Reporter:
            olivier soyez
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development