Solr
  1. Solr
  2. SOLR-5318

create command don't take into account the transient core property

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.4, 4.6
    • Fix Version/s: 4.6, Trunk
    • Component/s: multicore
    • Labels:
      None

      Description

      the create core admin command don't take into account the transient core property, when the core is registered (so, the core will be never closed by the transient core cache)

      To reproduce :
      set transientCacheSize=2 and start with no cores

      Create 3 cores :
      curl "http://ip:port/solr/admin/cores?action=CREATE&name=coreX&instanceDir=path_to_instanceDir_coreX&dataDir=path_to_dataDir_coreX&loadOnStartup=false&transient=true"

      Look at the status :
      http://ip:port/solr/admin/cores?action=STATUS

      All cores are still loaded.
      One core should not be loaded (closed by the transient cache)

      The patch in attachment is for svn solr branch_4X (revision number 1526418)

      1. SOLR-5318.patch
        5 kB
        Erick Erickson
      2. SOLR-5318.patch
        2 kB
        olivier soyez

        Issue Links

          Activity

          olivier soyez created issue -
          olivier soyez made changes -
          Field Original Value New Value
          Attachment SOLR-5318.patch [ 12607377 ]
          Hide
          Erick Erickson added a comment -

          Your other bug indicated you were using 4.2.1. See SOLR-4862, I believe this was fixed in Solr 4.4, could you possibly try that version?

          Thanks,
          Erick

          Show
          Erick Erickson added a comment - Your other bug indicated you were using 4.2.1. See SOLR-4862 , I believe this was fixed in Solr 4.4, could you possibly try that version? Thanks, Erick
          Erick Erickson made changes -
          Link This issue is related to SOLR-4862 [ SOLR-4862 ]
          Hide
          Erick Erickson added a comment -

          Sounds like issues encountered with SOLR-4862 and fixe din 4.4

          Show
          Erick Erickson added a comment - Sounds like issues encountered with SOLR-4862 and fixe din 4.4
          Erick Erickson made changes -
          Assignee Erick Erickson [ erickerickson ]
          olivier soyez made changes -
          Description the create core admin command don't take into account the transient core property, when the core is registered (so, the core will be never closed by the transient core cache)
          the create core admin command don't take into account the transient core property, when the core is registered (so, the core will be never closed by the transient core cache)

          To reproduce :
          set transientCacheSize=2 and start with no cores

          Create 3 cores :
          curl "http://ip:port/solr/admin/cores?action=CREATE&name=coreX&instanceDir=path_to_instanceDir_coreX&dataDir=path_to_dataDir_coreX&loadOnStartup=false&transient=true"

          Look at the status :
          http://ip:port/solr/admin/cores?action=STATUS

          All cores are still loaded.
          One core should not be loaded (closed by the transient cache).
          olivier soyez made changes -
          Description the create core admin command don't take into account the transient core property, when the core is registered (so, the core will be never closed by the transient core cache)

          To reproduce :
          set transientCacheSize=2 and start with no cores

          Create 3 cores :
          curl "http://ip:port/solr/admin/cores?action=CREATE&name=coreX&instanceDir=path_to_instanceDir_coreX&dataDir=path_to_dataDir_coreX&loadOnStartup=false&transient=true"

          Look at the status :
          http://ip:port/solr/admin/cores?action=STATUS

          All cores are still loaded.
          One core should not be loaded (closed by the transient cache).
          the create core admin command don't take into account the transient core property, when the core is registered (so, the core will be never closed by the transient core cache)

          To reproduce :
          set transientCacheSize=2 and start with no cores

          Create 3 cores :
          curl "http://ip:port/solr/admin/cores?action=CREATE&name=coreX&instanceDir=path_to_instanceDir_coreX&dataDir=path_to_dataDir_coreX&loadOnStartup=false&transient=true"

          Look at the status :
          http://ip:port/solr/admin/cores?action=STATUS

          All cores are still loaded.
          One core should not be loaded (closed by the transient cache)
          Hide
          olivier soyez added a comment -

          We are using in production solr 4.2.1, but I also test solr 4.4 and the svn solr branch_4X : same issue
          I complete the description and the way to reproduce the issue
          Not correlated with SOLR-4862

          Show
          olivier soyez added a comment - We are using in production solr 4.2.1, but I also test solr 4.4 and the svn solr branch_4X : same issue I complete the description and the way to reproduce the issue Not correlated with SOLR-4862
          olivier soyez made changes -
          Affects Version/s 4.4 [ 12324324 ]
          olivier soyez made changes -
          Description the create core admin command don't take into account the transient core property, when the core is registered (so, the core will be never closed by the transient core cache)

          To reproduce :
          set transientCacheSize=2 and start with no cores

          Create 3 cores :
          curl "http://ip:port/solr/admin/cores?action=CREATE&name=coreX&instanceDir=path_to_instanceDir_coreX&dataDir=path_to_dataDir_coreX&loadOnStartup=false&transient=true"

          Look at the status :
          http://ip:port/solr/admin/cores?action=STATUS

          All cores are still loaded.
          One core should not be loaded (closed by the transient cache)
          the create core admin command don't take into account the transient core property, when the core is registered (so, the core will be never closed by the transient core cache)

          To reproduce :
          set transientCacheSize=2 and start with no cores

          Create 3 cores :
          curl "http://ip:port/solr/admin/cores?action=CREATE&name=coreX&instanceDir=path_to_instanceDir_coreX&dataDir=path_to_dataDir_coreX&loadOnStartup=false&transient=true"

          Look at the status :
          http://ip:port/solr/admin/cores?action=STATUS

          All cores are still loaded.
          One core should not be loaded (closed by the transient cache)

          The patch in attachment is for svn solr branch_4X (revision number 1526418)
          Hide
          Erick Erickson added a comment -

          New patch with tests, committing shortly. I changed Oliver's approach a bit so we don't need new methods in CoreContainer.

          I'm not quite sure we really need all the variants of register, it seems like we always have things like the core name, whether the core is transient, all that stuff already in the CoreDescriptor we pass around, except maybe in the case of renaming the core. Could all this be made simpler? But that's for another day.

          Show
          Erick Erickson added a comment - New patch with tests, committing shortly. I changed Oliver's approach a bit so we don't need new methods in CoreContainer. I'm not quite sure we really need all the variants of register, it seems like we always have things like the core name, whether the core is transient, all that stuff already in the CoreDescriptor we pass around, except maybe in the case of renaming the core. Could all this be made simpler? But that's for another day.
          Erick Erickson made changes -
          Attachment SOLR-5318.patch [ 12612376 ]
          Hide
          ASF subversion and git services added a comment -

          Commit 1539343 from Erick Erickson in branch 'dev/trunk'
          [ https://svn.apache.org/r1539343 ]

          SOLR-5318: create HTTP API command doesn't respect transient core property

          Show
          ASF subversion and git services added a comment - Commit 1539343 from Erick Erickson in branch 'dev/trunk' [ https://svn.apache.org/r1539343 ] SOLR-5318 : create HTTP API command doesn't respect transient core property
          Hide
          ASF subversion and git services added a comment -

          Commit 1539360 from Erick Erickson in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1539360 ]

          SOLR-5318: create HTTP API command doesn't respect transient core property

          Show
          ASF subversion and git services added a comment - Commit 1539360 from Erick Erickson in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1539360 ] SOLR-5318 : create HTTP API command doesn't respect transient core property
          Hide
          Erick Erickson added a comment -

          Thanks Oliver!

          Show
          Erick Erickson added a comment - Thanks Oliver!
          Erick Erickson made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s 4.6 [ 12325000 ]
          Fix Version/s 5.0 [ 12321664 ]
          Resolution Fixed [ 1 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          28d 23h 2m 1 Erick Erickson 06/Nov/13 15:37

            People

            • Assignee:
              Erick Erickson
              Reporter:
              olivier soyez
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development