Solr
  1. Solr
  2. SOLR-531

rsyncd-start and snappuller should exit with different exit code when disabled

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.3
    • Fix Version/s: 1.3
    • Component/s: replication (scripts)
    • Labels:
      None

      Description

      When the rsyncd-start and snappuller scripts get executed the scripts check if they are enabled or not. If they are disabled they exit with 1. The scripts exit with 1 on error as well. So you cannot decide in upstream scripts if really an error occurred or if they are only disabled.

      1. SOLR-531.patch
        0.7 kB
        Thomas Peuss

        Activity

        Hide
        Thomas Peuss added a comment -

        The patch changes the exit code to 2 when the scripts are disabled.

        Show
        Thomas Peuss added a comment - The patch changes the exit code to 2 when the scripts are disabled.
        Hide
        Bill Au added a comment -

        The patch looks good to me. I will apply it if no one objects.

        Show
        Bill Au added a comment - The patch looks good to me. I will apply it if no one objects.
        Hide
        Bill Au added a comment -

        Patch committed:

        Sending CHANGES.txt
        Sending src/scripts/rsyncd-start
        Sending src/scripts/snappuller
        Transmitting file data ...
        Committed revision 645608.

        Thanks, Thomas.

        Show
        Bill Au added a comment - Patch committed: Sending CHANGES.txt Sending src/scripts/rsyncd-start Sending src/scripts/snappuller Transmitting file data ... Committed revision 645608. Thanks, Thomas.
        Hide
        Hoss Man added a comment -

        This bug was modified as part of a bulk update using the criteria...

        • Currently marked ("Resolved" or "Closed") and "Fixed"
        • Had no "Fix Version" versions
        • "Affects Versions" included 1.3

        The Fix Version for all 8 issues found was set to 1.3 (1.3 has not yet been released, if an issue is already fixed, and it affected 1.3 then the fix will be in 1.3)

        Email notification was suppressed to prevent excessive email.

        For a list of all the issues modified, search jira comments for this
        (hopefully) unique string: 20080415hossman1

        Show
        Hoss Man added a comment - This bug was modified as part of a bulk update using the criteria... Currently marked ("Resolved" or "Closed") and "Fixed" Had no "Fix Version" versions "Affects Versions" included 1.3 The Fix Version for all 8 issues found was set to 1.3 (1.3 has not yet been released, if an issue is already fixed, and it affected 1.3 then the fix will be in 1.3) Email notification was suppressed to prevent excessive email. For a list of all the issues modified, search jira comments for this (hopefully) unique string: 20080415hossman1

          People

          • Assignee:
            Bill Au
            Reporter:
            Thomas Peuss
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development