Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-5257

confusing warning logged when unexpected xml attributes are found

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.7, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      Brian Robinson on the solr-user list got really confused by this warning message...

      Unknown attribute id in add:allowDups

      ...the mention of "id" in that warning was a big red herring that led him to assume something was wrong with the "id" in his documents, because it's not at all clear that's refering to the "xml node id" of an unexpected "xml attribute" (which in this case is "allowDups")

      filing this issue so i remembe to fix this warning to be more helpful, and review the rest of the file while i'm at it for other confusing warnings.

      1. SOLR-5257.patch
        1 kB
        Vitaliy Zhovtyuk
      2. SOLR-5257.patch
        4 kB
        Hoss Man

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1567711 from hossman@apache.org in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1567711 ]

        SOLR-5257: Improved error/warn messages when Update XML contains unexpected XML nodes (merge r1567706)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1567711 from hossman@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1567711 ] SOLR-5257 : Improved error/warn messages when Update XML contains unexpected XML nodes (merge r1567706)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1567706 from hossman@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1567706 ]

        SOLR-5257: Improved error/warn messages when Update XML contains unexpected XML nodes

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1567706 from hossman@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1567706 ] SOLR-5257 : Improved error/warn messages when Update XML contains unexpected XML nodes
        Hide
        hossman Hoss Man added a comment -

        Fixed warning messages

        Thanks Vitaliy, but what i had in mind was to be more complete and audit all of the warnings produced by this class to make sure they are unambiguous for end users.

        Attaching updated patch ... anyone see any concerns with these message changes?

        Show
        hossman Hoss Man added a comment - Fixed warning messages Thanks Vitaliy, but what i had in mind was to be more complete and audit all of the warnings produced by this class to make sure they are unambiguous for end users. Attaching updated patch ... anyone see any concerns with these message changes?
        Hide
        vzhovtiuk Vitaliy Zhovtyuk added a comment -

        Fixed warning messages
        I have not added TODOs, but few if's in this class can be replaced with switch for clarity: starting at lines 221, 233, 299
        Maybe improve this in future.

        Show
        vzhovtiuk Vitaliy Zhovtyuk added a comment - Fixed warning messages I have not added TODOs, but few if's in this class can be replaced with switch for clarity: starting at lines 221, 233, 299 Maybe improve this in future.
        Hide
        hossman Hoss Man added a comment - - edited

        EDIT: sorry, got my issue numbers confused, and accidentally commented & committed some stuff using this issue number that was meant for SOLR-5085.

        Show
        hossman Hoss Man added a comment - - edited EDIT: sorry, got my issue numbers confused, and accidentally commented & committed some stuff using this issue number that was meant for SOLR-5085 .

          People

          • Assignee:
            hossman Hoss Man
            Reporter:
            hossman Hoss Man
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development