Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-5228

Deprecate <fields> and <types> tags in schema.xml

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 4.8, 6.0
    • Schema and Analysis
    • None

    Description

      On the solr-user mailing list, Nutan recently mentioned spending days trying to track down a problem that turned out to be because he had attempted to add a <dynamicField .. /> that was outside of the <fields> block in his schema.xml – Solr was just silently ignoring it.

      We have made improvements in other areas of config validation by generating statup errors when tags/attributes are found that are not expected – but in this case i think we should just stop expecting/requiring that the <fields> and <types> tags will be used to group these sorts of things. I think schema.xml parsing should just start ignoring them and only care about finding the <field>, <dynamicField>, and <fieldType> tags wherever they may be.

      If people want to keep using them, fine. If people want to mix fieldTypes and fields side by side (perhaps specify a fieldType, then list all the fields using it) fine. I don't see any value in forcing people to use them, but we definitely shouldn't leave things the way they are with otherwise perfectly valid field/type declarations being silently ignored.

      I'll take this on unless i see any objections.

      Attachments

        1. SOLR-5228.patch
          11 kB
          Erick Erickson
        2. SOLR-5228.patch
          21 kB
          Erick Erickson

        Activity

          People

            erickerickson Erick Erickson
            hossman Chris M. Hostetter
            Votes:
            0 Vote for this issue
            Watchers:
            14 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: