Solr
  1. Solr
  2. SOLR-5206

OpenExchangeRatesOrgProvider never refreshes the rates

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Critical Critical
        • Resolution: Fixed
        • Affects Version/s: 4.4
        • Fix Version/s: 4.5, 5.0
        • Component/s: Schema and Analysis
        • Labels:
          None

          Description

          The OpenExchangeRatesOrgProvider never reloads the rates after the initial load, no matter what refreshInterval is set.

          1. Text File
            fixRefresh.patch
            0.6 kB
            Catalin
          2. Text File
            SOLR-5206.patch
            6 kB
            Hoss Man

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Catalin added a comment - - edited

            I've attached a patch which fixes this issue. The problem was with how the condition was set (it should have been reversed) and the fact that timestamp is in seconds, not miliseconds.

            Show
            Catalin added a comment - - edited I've attached a patch which fixes this issue. The problem was with how the condition was set (it should have been reversed) and the fact that timestamp is in seconds, not miliseconds.
            Hide
            Permalink
            Hoss Man added a comment -

            Bahg!

            That's terrible .. thanks for reporting this and identifying the fix Catalin.

            I've attached a patch including Catalin's fix (along with a bit of refactoring the match) and a fix so that the "reload" test actually tests something useful.

            doing more testing now.

            Show
            Hoss Man added a comment - Bahg! That's terrible .. thanks for reporting this and identifying the fix Catalin. I've attached a patch including Catalin's fix (along with a bit of refactoring the match) and a fix so that the "reload" test actually tests something useful. doing more testing now.
            Hide
            Permalink
            ASF subversion and git services added a comment -

            Commit 1519858 from hossman@apache.org in branch 'dev/trunk'
            [ https://svn.apache.org/r1519858 ]

            SOLR-5206: Fixed OpenExchangeRatesOrgProvider to use refreshInterval correctly

            Show
            ASF subversion and git services added a comment - Commit 1519858 from hossman@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1519858 ] SOLR-5206 : Fixed OpenExchangeRatesOrgProvider to use refreshInterval correctly
            Hide
            Permalink
            ASF subversion and git services added a comment -

            Commit 1519865 from hossman@apache.org in branch 'dev/branches/branch_4x'
            [ https://svn.apache.org/r1519865 ]

            SOLR-5206: Fixed OpenExchangeRatesOrgProvider to use refreshInterval correctly (merge r1519858)

            Show
            ASF subversion and git services added a comment - Commit 1519865 from hossman@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1519865 ] SOLR-5206 : Fixed OpenExchangeRatesOrgProvider to use refreshInterval correctly (merge r1519858)
            Hide
            Permalink
            Hoss Man added a comment -

            Thanks for reporting this Catalin.

            Show
            Hoss Man added a comment - Thanks for reporting this Catalin.
            Hide
            Permalink
            Adrien Grand added a comment -

            4.5 release -> bulk close

            Show
            Adrien Grand added a comment - 4.5 release -> bulk close

              People

              • Assignee:
                Hoss Man
                Reporter:
                Catalin
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development