Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-5206

OpenExchangeRatesOrgProvider never refreshes the rates

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 4.4
    • Fix Version/s: 4.5, 6.0
    • Component/s: Schema and Analysis
    • Labels:
      None

      Description

      The OpenExchangeRatesOrgProvider never reloads the rates after the initial load, no matter what refreshInterval is set.

      1. fixRefresh.patch
        0.6 kB
        Catalin
      2. SOLR-5206.patch
        6 kB
        Hoss Man

        Activity

        Hide
        wiseon3 Catalin added a comment - - edited

        I've attached a patch which fixes this issue. The problem was with how the condition was set (it should have been reversed) and the fact that timestamp is in seconds, not miliseconds.

        Show
        wiseon3 Catalin added a comment - - edited I've attached a patch which fixes this issue. The problem was with how the condition was set (it should have been reversed) and the fact that timestamp is in seconds, not miliseconds.
        Hide
        hossman Hoss Man added a comment -

        Bahg!

        That's terrible .. thanks for reporting this and identifying the fix Catalin.

        I've attached a patch including Catalin's fix (along with a bit of refactoring the match) and a fix so that the "reload" test actually tests something useful.

        doing more testing now.

        Show
        hossman Hoss Man added a comment - Bahg! That's terrible .. thanks for reporting this and identifying the fix Catalin. I've attached a patch including Catalin's fix (along with a bit of refactoring the match) and a fix so that the "reload" test actually tests something useful. doing more testing now.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1519858 from hossman@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1519858 ]

        SOLR-5206: Fixed OpenExchangeRatesOrgProvider to use refreshInterval correctly

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1519858 from hossman@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1519858 ] SOLR-5206 : Fixed OpenExchangeRatesOrgProvider to use refreshInterval correctly
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1519865 from hossman@apache.org in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1519865 ]

        SOLR-5206: Fixed OpenExchangeRatesOrgProvider to use refreshInterval correctly (merge r1519858)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1519865 from hossman@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1519865 ] SOLR-5206 : Fixed OpenExchangeRatesOrgProvider to use refreshInterval correctly (merge r1519858)
        Hide
        hossman Hoss Man added a comment -

        Thanks for reporting this Catalin.

        Show
        hossman Hoss Man added a comment - Thanks for reporting this Catalin.
        Hide
        jpountz Adrien Grand added a comment -

        4.5 release -> bulk close

        Show
        jpountz Adrien Grand added a comment - 4.5 release -> bulk close

          People

          • Assignee:
            hossman Hoss Man
            Reporter:
            wiseon3 Catalin
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development