Solr
  1. Solr
  2. SOLR-5190

SolrEntityProcessor substitutes variables only once in child entities

    Details

      Description

      As noted by users on the mailing list and elsewhere, SolrEntityProcessor cannot be used in a child entity because it substitutes variables only once.

      http://www.mail-archive.com/solr-user@lucene.apache.org/msg88002.html
      http://stackoverflow.com/questions/15734308/solrentityprocessor-is-called-only-once-for-sub-entities?lq=1

      SOLR-3336 attempted to fix the problem by moving variable substitution to the doQuery method but that fix is not complete because the doQuery method is called only once.

      1. SOLR-5190.patch
        5 kB
        Shalin Shekhar Mangar

        Issue Links

          Activity

          Hide
          Shalin Shekhar Mangar added a comment -

          Test + fix attached.

          I removed the initDone boolean flag. Added a test in TestSolrEntityProcessorEndToEnd which invokes nested SolrEntityProcessor more than once.

          Show
          Shalin Shekhar Mangar added a comment - Test + fix attached. I removed the initDone boolean flag. Added a test in TestSolrEntityProcessorEndToEnd which invokes nested SolrEntityProcessor more than once.
          Hide
          ASF subversion and git services added a comment -

          Commit 1518161 from shalin@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1518161 ]

          SOLR-5190: SolrEntityProcessor substitutes variables only once in child entities

          Show
          ASF subversion and git services added a comment - Commit 1518161 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1518161 ] SOLR-5190 : SolrEntityProcessor substitutes variables only once in child entities
          Hide
          ASF subversion and git services added a comment -

          Commit 1518165 from shalin@apache.org in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1518165 ]

          SOLR-5190: SolrEntityProcessor substitutes variables only once in child entities

          Show
          ASF subversion and git services added a comment - Commit 1518165 from shalin@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1518165 ] SOLR-5190 : SolrEntityProcessor substitutes variables only once in child entities
          Hide
          Adrien Grand added a comment -

          4.5 release -> bulk close

          Show
          Adrien Grand added a comment - 4.5 release -> bulk close
          Hide
          Dominik Siebel added a comment -

          Shalin Shekhar Mangar, Adrien Grand Is there any chance, this will be merged to branch lucene_solr_4_3 / lucene_solr_4_4 ?

          Show
          Dominik Siebel added a comment - Shalin Shekhar Mangar , Adrien Grand Is there any chance, this will be merged to branch lucene_solr_4_3 / lucene_solr_4_4 ?
          Hide
          Erick Erickson added a comment -

          bq: Is there any chance, this will be merged to branch lucene_solr_4_3 / lucene_solr_4_4

          Probably not. Someone would have to volunteer to be the release manager for, say, a 4.4.1 release or whatever and everyone's time is extremely limited.

          It would be pretty straight forward for you to check out the code branch for 4.4, apply the patch locally and compile if it's important enough though.

          Erick

          Show
          Erick Erickson added a comment - bq: Is there any chance, this will be merged to branch lucene_solr_4_3 / lucene_solr_4_4 Probably not. Someone would have to volunteer to be the release manager for, say, a 4.4.1 release or whatever and everyone's time is extremely limited. It would be pretty straight forward for you to check out the code branch for 4.4, apply the patch locally and compile if it's important enough though. Erick
          Hide
          Dominik Siebel added a comment -

          [~steamedcotton] Already did (forked github mirror). Just thought it would be nice to have it in the upstream. Thanks for the reply!

          Show
          Dominik Siebel added a comment - [~steamedcotton] Already did (forked github mirror). Just thought it would be nice to have it in the upstream. Thanks for the reply!

            People

            • Assignee:
              Shalin Shekhar Mangar
              Reporter:
              Shalin Shekhar Mangar
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development