Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.5, Trunk
    • Component/s: None
    • Labels:
      None

      Description

      there is a lot of sprinkled arround checks in unrelated to ensure that indexConfig option parsing picks up the correct merge policy and merge schedulre and what not.

      as part of switching all of these tests to use randomized indexConfig options, we need to ensure that this kind of testing for explicitly specified config is rock solid.

        Activity

        Hide
        ASF subversion and git services added a comment -

        Commit 1510830 from hossman@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1510830 ]

        SOLR-5118: beef up assertions in SolrIndexConfigTest, this allows us to remove TestPropInject and TestPropInjectDefaults – neither of which were testing property injection (tested elsewhere) but were doing some basic assertions on the parsing & init of merge policy and merge scheduler

        Show
        ASF subversion and git services added a comment - Commit 1510830 from hossman@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1510830 ] SOLR-5118 : beef up assertions in SolrIndexConfigTest, this allows us to remove TestPropInject and TestPropInjectDefaults – neither of which were testing property injection (tested elsewhere) but were doing some basic assertions on the parsing & init of merge policy and merge scheduler
        Hide
        ASF subversion and git services added a comment -

        Commit 1510833 from hossman@apache.org in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1510833 ]

        SOLR-5118: beef up assertions in SolrIndexConfigTest, this allows us to remove TestPropInject and TestPropInjectDefaults – neither of which were testing property injection (tested elsewhere) but were doing some basic assertions on the parsing & init of merge policy and merge scheduler (merge r1510830)

        Show
        ASF subversion and git services added a comment - Commit 1510833 from hossman@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1510833 ] SOLR-5118 : beef up assertions in SolrIndexConfigTest, this allows us to remove TestPropInject and TestPropInjectDefaults – neither of which were testing property injection (tested elsewhere) but were doing some basic assertions on the parsing & init of merge policy and merge scheduler (merge r1510830)
        Hide
        ASF subversion and git services added a comment -

        Commit 1518352 from hossman@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1518352 ]

        SOLR-5118: more testing of edge case and some error conditions

        Show
        ASF subversion and git services added a comment - Commit 1518352 from hossman@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1518352 ] SOLR-5118 : more testing of edge case and some error conditions
        Hide
        ASF subversion and git services added a comment -

        Commit 1518379 from hossman@apache.org in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1518379 ]

        SOLR-5118: more testing of edge case and some error conditions (merge r1518352)

        Show
        ASF subversion and git services added a comment - Commit 1518379 from hossman@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1518379 ] SOLR-5118 : more testing of edge case and some error conditions (merge r1518352)
        Hide
        Hoss Man added a comment -

        I'm pretty happy with what we've got at this point, and the code coverage metrics for SolrIndexConfig are looking decent.

        Show
        Hoss Man added a comment - I'm pretty happy with what we've got at this point, and the code coverage metrics for SolrIndexConfig are looking decent.
        Hide
        Adrien Grand added a comment -

        4.5 release -> bulk close

        Show
        Adrien Grand added a comment - 4.5 release -> bulk close

          People

          • Assignee:
            Hoss Man
            Reporter:
            Hoss Man
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development