Solr
  1. Solr
  2. SOLR-5107

LukeRequestHandler throws NullPointerException when numTerms=0

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.4
    • Fix Version/s: 4.5, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      Defaults example http://localhost:8983/solr/collection1/admin/luke?fl=cat&numTerms=0 yields

      ERROR org.apache.solr.core.SolrCore  – java.lang.NullPointerException
      	at org.apache.solr.handler.admin.LukeRequestHandler.getDetailedFieldInfo(LukeRequestHandler.java:610)
      	at org.apache.solr.handler.admin.LukeRequestHandler.getIndexedFieldsInfo(LukeRequestHandler.java:378)
      	at org.apache.solr.handler.admin.LukeRequestHandler.handleRequestBody(LukeRequestHandler.java:160)
      	at org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:135)
      	at org.apache.solr.core.SolrCore.execute(SolrCore.java:1845)
      	at org.apache.solr.servlet.SolrDispatchFilter.execute(SolrDispatchFilter.java:666)
      	at org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:369)
      	at org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:158)
      	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1419)
      	at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:455)
      	at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137)
      	at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:557)
      	at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:231)
      	at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1075)
      	at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:384)
      	at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193)
      	at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1009)
      	at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135)
      	at org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:255)
      	at org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:154)
      	at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:116)
      	at org.eclipse.jetty.server.Server.handle(Server.java:368)
      	at org.eclipse.jetty.server.AbstractHttpConnection.handleRequest(AbstractHttpConnection.java:489)
      	at org.eclipse.jetty.server.BlockingHttpConnection.handleRequest(BlockingHttpConnection.java:53)
      	at org.eclipse.jetty.server.AbstractHttpConnection.headerComplete(AbstractHttpConnection.java:942)
      	at org.eclipse.jetty.server.AbstractHttpConnection$RequestHandler.headerComplete(AbstractHttpConnection.java:1004)
      	at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:640)
      	at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:235)
      	at org.eclipse.jetty.server.BlockingHttpConnection.handle(BlockingHttpConnection.java:72)
      	at org.eclipse.jetty.server.bio.SocketConnector$ConnectorEndPoint.run(SocketConnector.java:264)
      	at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:608)
      	at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:543)
      	at java.lang.Thread.run(Thread.java:722)
      
      1. SOLR-5107.patch
        3 kB
        Hoss Man
      2. SOLR-5107.patch
        0.9 kB
        Ahmet Arslan

        Activity

        Hide
        Hoss Man added a comment -

        Ahmet: thanks for reporting this, and thanks for your patch – but i think a better solution would be to completely short circuit out of decoding the term and adding to the TopTermQueue unless "0 < numTerms"

        Here's a patch with what i have in mind and some new tests ... anyone see any problems with this approach? (it still gathers the histogram stats, it just doesn't bother to use constantly add/pop from the TopTermQueue)

        Show
        Hoss Man added a comment - Ahmet: thanks for reporting this, and thanks for your patch – but i think a better solution would be to completely short circuit out of decoding the term and adding to the TopTermQueue unless "0 < numTerms" Here's a patch with what i have in mind and some new tests ... anyone see any problems with this approach? (it still gathers the histogram stats, it just doesn't bother to use constantly add/pop from the TopTermQueue)
        Hide
        Erick Erickson added a comment -

        Hoss:

        Looks good to me.

        Show
        Erick Erickson added a comment - Hoss: Looks good to me.
        Hide
        ASF subversion and git services added a comment -

        Commit 1511064 from hossman@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1511064 ]

        SOLR-5107: Fixed NPE when using numTerms=0 in LukeRequestHandler

        Show
        ASF subversion and git services added a comment - Commit 1511064 from hossman@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1511064 ] SOLR-5107 : Fixed NPE when using numTerms=0 in LukeRequestHandler
        Hide
        ASF subversion and git services added a comment -

        Commit 1511069 from hossman@apache.org in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1511069 ]

        SOLR-5107: Fixed NPE when using numTerms=0 in LukeRequestHandler (merge r1511064)

        Show
        ASF subversion and git services added a comment - Commit 1511069 from hossman@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1511069 ] SOLR-5107 : Fixed NPE when using numTerms=0 in LukeRequestHandler (merge r1511064)
        Hide
        Hoss Man added a comment -

        thanks Ahmet and Erick

        Show
        Hoss Man added a comment - thanks Ahmet and Erick
        Hide
        Adrien Grand added a comment -

        4.5 release -> bulk close

        Show
        Adrien Grand added a comment - 4.5 release -> bulk close

          People

          • Assignee:
            Hoss Man
            Reporter:
            Ahmet Arslan
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development