Rough draft comments. I won't be able to do anything more until this evening (Pacific time), in meetings all day.
1> What do you (and others) think about putting the enum right in the schema.xml file,
perhaps as as many children of <fields><enum></enum><enum></enum></fields> as necessary?
That would at least keep them together and not introduce a separate file.
1.5> There's still the IntelliJ headers in the new files, should be removed.
SOLRINPUTDOC_CHILDS = 17,
//Why is this value identical to SOLRINPUTDOC_CHILDS? It may be fine, verifying
ENUM_FIELD_VALUE = 17,
3> StatsValuesFactory.updateMinMax. How does this.max ever get set to non-null?
> You have a custom field isNullOrEmpty. There's nothing wrong with this,
but StringUtils.isBlank already takes care of this, less code to maintain.
> storedToIndexed isn't referenced and, at least in trunk, doesn't show as being
overridden (haven't checked 4x). May be OK but....
> How about a couple of tests that exercise inclusive and exclusive ranges with defined
endpoints rather than [* TO *]?
> The general coding practice (even though I like the leading underscore for member
vars personally) is to not have them, please change.