[SOLR-5040] SnapShooter doesn't create a lock as it runs

• Type: Bug
• Status: Open
• Priority: Trivial
• Resolution: Unresolved
• Component/s: replication (java)
• Assignee: Unassigned
• Reporter: Mark Triggs
• Created: 14/Jul/13 04:21
• Updated: 16/Feb/22 00:21

Description

Hi there,

While messing around with the replication handler recently, I noticed that the snapshooter didn't seem to be writing a lock file. I had a look at the SnapShooter.java code, and to my untrained eye it seemed like it was creating a Lock object but never actually taking a lock.

I modified my local installation to use lock.obtain() instead of lock.isLocked() and verified that I'm now seeing lock files. I've attached a very small patch just in case this is a genuine bug.

Cheers,

Mark