Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-5028

Incorrect ShardHandlerFactory creation

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 4.4, 6.0
    • 4.5, 6.0
    • None
    • None

    Description

      It seems to me that there are two bugs in the ShardHandlerFactoryCreation that cancel each other and it seems to be working with the old style solr.xml, but not with the "new style". ConfigSolrOldXml seems to be expecting the shardHandlerFactory with the xpath:
      solr/shardHandlerFactory/@class
      Instead of solr/cores/shardHandlerFactory/@class as it used to be. This is never caught because in the CoreContainer the ShardHandlerFactory is initialized using "configSolr.getConfig().getNode("solr/cores/shardHandlerFactory", false);" instead of "configSolr.get(CfgProp.SOLR_SHARDHANDLERFACTORY_CLASS, null);" or something like that. However, if you use the "new style" xml, the CoreContainer will still try to initialize the factory like that, and won't find the SHF.

      Attachments

        1. SOLR-5028.patch
          27 kB
          Alan Woodward
        2. SOLR-5028.patch
          24 kB
          Tomas Eduardo Fernandez Lobbe
        3. SOLR-5028.patch
          20 kB
          Alan Woodward
        4. SOLR-5028.patch
          20 kB
          Alan Woodward
        5. SOLR-5028.patch
          9 kB
          Alan Woodward
        6. SOLR-5082.patch
          5 kB
          Ryan Ernst

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            romseygeek Alan Woodward
            tflobbe Tomas Eduardo Fernandez Lobbe
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment