deleteInstanceDir is added to CoreAdminHandler but is not supported in Unload CoreAdminRequest
We should add the deleteDataDir option as well. I guess the best workaround for now is to simply subclass the Unload CoreAdminRequest and add the param in getParams.
Patch for review. Created for 4.3.1 version.
Did anyone have a chance to look at the code?
deleteDataDir option was already added (at least in 4.3.1 version).
Patch looks good. I'll commit shortly.
I reviewed the patch the other day, looks good, but it still needs a test that uses the new code.
Added a test for deleteInstanceDir
I saw that you had added a test for the patch. Thank you very much.
As I understand the last released version 4.5 doesn't include the fix.
What should be done in order to commit the patch?
I forgot to link this issue to SOLR-4817. The attached test fails because the copySolrHomeToTemp methods don't work well with our test scripts. See https://issues.apache.org/jira/browse/SOLR-4817?focusedCommentId=13760008&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13760008
Until SOLR-4817 is fixed, we can separate the test into its own issue and commit the solrj changes.
Here's a patch with a working test. Since the copySolrHomeToTemp methods don't work with solrj tests yet, I moved the test to CoreAdminHandlerTest which is part of solr core.
Commit 1546793 from firstname.lastname@example.org in branch 'dev/trunk'
[ https://svn.apache.org/r1546793 ]
SOLR-5023: Add support for deleteInstanceDir to be passed from SolrJ for Core Unload action
Commit 1546794 from email@example.com in branch 'dev/branches/branch_4x'
[ https://svn.apache.org/r1546794 ]
Commit 1546795 from firstname.lastname@example.org in branch 'dev/trunk'
[ https://svn.apache.org/r1546795 ]
SOLR-5023: Add attribution to issue reporter
Commit 1546796 from email@example.com in branch 'dev/branches/branch_4x'
[ https://svn.apache.org/r1546796 ]