Solr
  1. Solr
  2. SOLR-5023

deleteInstanceDir is added to CoreAdminHandler but can't be passed with solrj

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.2.1
    • Fix Version/s: 4.7, 6.0
    • Component/s: multicore
    • Labels:
      None

      Description

      deleteInstanceDir is added to CoreAdminHandler but is not supported in Unload CoreAdminRequest

      1. SOLR-5023.patch
        5 kB
        Shalin Shekhar Mangar
      2. SOLR-5023.patch
        4 kB
        Shalin Shekhar Mangar
      3. SOLR-5023.patch
        2 kB
        Lyubov Romanchuk

        Activity

        Hide
        Mark Miller added a comment -

        We should add the deleteDataDir option as well. I guess the best workaround for now is to simply subclass the Unload CoreAdminRequest and add the param in getParams.

        Show
        Mark Miller added a comment - We should add the deleteDataDir option as well. I guess the best workaround for now is to simply subclass the Unload CoreAdminRequest and add the param in getParams.
        Hide
        Lyubov Romanchuk added a comment -

        Patch for review. Created for 4.3.1 version.

        Show
        Lyubov Romanchuk added a comment - Patch for review. Created for 4.3.1 version.
        Hide
        Lyubov Romanchuk added a comment -

        Did anyone have a chance to look at the code?
        deleteDataDir option was already added (at least in 4.3.1 version).

        Show
        Lyubov Romanchuk added a comment - Did anyone have a chance to look at the code? deleteDataDir option was already added (at least in 4.3.1 version).
        Hide
        Shalin Shekhar Mangar added a comment -

        Patch looks good. I'll commit shortly.

        Show
        Shalin Shekhar Mangar added a comment - Patch looks good. I'll commit shortly.
        Hide
        Mark Miller added a comment -

        I reviewed the patch the other day, looks good, but it still needs a test that uses the new code.

        Show
        Mark Miller added a comment - I reviewed the patch the other day, looks good, but it still needs a test that uses the new code.
        Hide
        Shalin Shekhar Mangar added a comment -

        Added a test for deleteInstanceDir

        Show
        Shalin Shekhar Mangar added a comment - Added a test for deleteInstanceDir
        Hide
        Lyubov Romanchuk added a comment -

        Hi Shalin,
        I saw that you had added a test for the patch. Thank you very much.
        As I understand the last released version 4.5 doesn't include the fix.
        What should be done in order to commit the patch?
        Thank you.
        Best regards.

        Show
        Lyubov Romanchuk added a comment - Hi Shalin, I saw that you had added a test for the patch. Thank you very much. As I understand the last released version 4.5 doesn't include the fix. What should be done in order to commit the patch? Thank you. Best regards.
        Hide
        Shalin Shekhar Mangar added a comment -

        I forgot to link this issue to SOLR-4817. The attached test fails because the copySolrHomeToTemp methods don't work well with our test scripts. See https://issues.apache.org/jira/browse/SOLR-4817?focusedCommentId=13760008&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13760008

        Until SOLR-4817 is fixed, we can separate the test into its own issue and commit the solrj changes.

        Show
        Shalin Shekhar Mangar added a comment - I forgot to link this issue to SOLR-4817 . The attached test fails because the copySolrHomeToTemp methods don't work well with our test scripts. See https://issues.apache.org/jira/browse/SOLR-4817?focusedCommentId=13760008&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13760008 Until SOLR-4817 is fixed, we can separate the test into its own issue and commit the solrj changes.
        Hide
        Shalin Shekhar Mangar added a comment -

        Here's a patch with a working test. Since the copySolrHomeToTemp methods don't work with solrj tests yet, I moved the test to CoreAdminHandlerTest which is part of solr core.

        Show
        Shalin Shekhar Mangar added a comment - Here's a patch with a working test. Since the copySolrHomeToTemp methods don't work with solrj tests yet, I moved the test to CoreAdminHandlerTest which is part of solr core.
        Hide
        ASF subversion and git services added a comment -

        Commit 1546793 from shalin@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1546793 ]

        SOLR-5023: Add support for deleteInstanceDir to be passed from SolrJ for Core Unload action

        Show
        ASF subversion and git services added a comment - Commit 1546793 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1546793 ] SOLR-5023 : Add support for deleteInstanceDir to be passed from SolrJ for Core Unload action
        Hide
        ASF subversion and git services added a comment -

        Commit 1546794 from shalin@apache.org in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1546794 ]

        SOLR-5023: Add support for deleteInstanceDir to be passed from SolrJ for Core Unload action

        Show
        ASF subversion and git services added a comment - Commit 1546794 from shalin@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1546794 ] SOLR-5023 : Add support for deleteInstanceDir to be passed from SolrJ for Core Unload action
        Hide
        ASF subversion and git services added a comment -

        Commit 1546795 from shalin@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1546795 ]

        SOLR-5023: Add attribution to issue reporter

        Show
        ASF subversion and git services added a comment - Commit 1546795 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1546795 ] SOLR-5023 : Add attribution to issue reporter
        Hide
        ASF subversion and git services added a comment -

        Commit 1546796 from shalin@apache.org in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1546796 ]

        SOLR-5023: Add attribution to issue reporter

        Show
        ASF subversion and git services added a comment - Commit 1546796 from shalin@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1546796 ] SOLR-5023 : Add attribution to issue reporter
        Hide
        Shalin Shekhar Mangar added a comment -

        Thanks Lyubov!

        Show
        Shalin Shekhar Mangar added a comment - Thanks Lyubov!

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            Lyubov Romanchuk
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development