Solr
  1. Solr
  2. SOLR-4976

info stream doesn't work with merged segment warmer

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.4, Trunk
    • Component/s: None
    • Labels:
      None

      Description

      In SolrIndexConfig, constructing the merged segment warmer takes an InfoStream, but InfoStream.NO_OUTPUT is hardcoded. Instead, the info stream should be constructed in SolrIndexConfig, instead of SolrIndexWriter where it is now, so that it can be used for the warmer.

      1. SOLR-4976.patch
        7 kB
        Ryan Ernst
      2. SOLR-4976.patch
        7 kB
        Ryan Ernst

        Activity

        Ryan Ernst created issue -
        Hide
        Robert Muir added a comment -

        +1... i TODO's this instead of cleaning up properly so that you get logging for the segment warming

        Show
        Robert Muir added a comment - +1... i TODO's this instead of cleaning up properly so that you get logging for the segment warming
        Hide
        Ryan Ernst added a comment -

        First try at a patch, with a simple test.

        Show
        Ryan Ernst added a comment - First try at a patch, with a simple test.
        Ryan Ernst made changes -
        Field Original Value New Value
        Attachment SOLR-4976.patch [ 12590081 ]
        Hide
        Mark Miller added a comment -

        Nice, +1.

        Show
        Mark Miller added a comment - Nice, +1.
        Hide
        Ryan Ernst added a comment -

        New patch removing null check on close() since IndexWriterConfig does not allow null for InfoStream.

        Show
        Ryan Ernst added a comment - New patch removing null check on close() since IndexWriterConfig does not allow null for InfoStream.
        Ryan Ernst made changes -
        Attachment SOLR-4976.patch [ 12590129 ]
        Hide
        Robert Muir added a comment -

        Thanks Ryan!

        Show
        Robert Muir added a comment - Thanks Ryan!
        Robert Muir made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 5.0 [ 12321664 ]
        Fix Version/s 4.4 [ 12324324 ]
        Resolution Fixed [ 1 ]
        Hide
        Steve Rowe added a comment -

        Bulk close resolved 4.4 issues

        Show
        Steve Rowe added a comment - Bulk close resolved 4.4 issues
        Steve Rowe made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        7h 12m 1 Robert Muir 29/Jun/13 02:49
        Resolved Resolved Closed Closed
        24d 16h 48m 1 Steve Rowe 23/Jul/13 19:38

          People

          • Assignee:
            Unassigned
            Reporter:
            Ryan Ernst
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development