Solr
  1. Solr
  2. SOLR-4966

CSS, JS and other files in webapp without license

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.4, Trunk
    • Component/s: web gui
    • Labels:
      None

      Description

      Almost all javascript and css in the Solr web app have no license. This violates ASF requirements, so it is a blocker, as we cannot do any other relaese without fixing

      1. SOLR-4966.patch
        76 kB
        Stefan Matheis (steffkes)
      2. SOLR-4966.patch
        73 kB
        Stefan Matheis (steffkes)
      3. SOLR-4966.patch
        73 kB
        Stefan Matheis (steffkes)
      4. SOLR-4966.patch
        71 kB
        Stefan Matheis (steffkes)
      5. SOLR-4966.patch
        2 kB
        Stefan Matheis (steffkes)
      6. SOLR-4966.patch
        0.9 kB
        Uwe Schindler

        Issue Links

          Activity

          Hide
          Uwe Schindler added a comment -

          The attached patch shows the problem, the following files have no license header and are also missing in NOTICE.txt (most of the files are 3rd party, so they must be listed with license in the NOTICE.txt):

               [echo] Unapproved licenses:
               [echo]
               [echo]   C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/WEB-INF/weblogic.xml
               [echo]   C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/css/chosen.css
               [echo]   C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/css/styles/analysis.css
               [echo]   C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/css/styles/cloud.css
               [echo]   C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/css/styles/common.css
               [echo]   C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/css/styles/cores.css
               [echo]   C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/css/styles/dashboard.css
               [echo]   C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/css/styles/dataimport.css
               [echo]   C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/css/styles/documents.css
               [echo]   C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/css/styles/index.css
               [echo]   C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/css/styles/java-properties.css
               [echo]   C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/css/styles/logging.css
               [echo]   C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/css/styles/menu.css
               [echo]   C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/css/styles/plugins.css
               [echo]   C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/css/styles/query.css
               [echo]   C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/css/styles/replication.css
               [echo]   C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/css/styles/schema-browser.css
               [echo]   C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/css/styles/threads.css
               [echo]   C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/js/lib/ZeroClipboard.js
               [echo]   C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/js/lib/chosen.js
               [echo]   C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/js/lib/d3.js
               [echo]   C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/js/lib/highlight.js
               [echo]   C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/js/lib/jquery-1.7.2.min.js
               [echo]   C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/js/lib/jquery.autogrow.js
               [echo]   C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/js/lib/jquery.blockUI.js
               [echo]   C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/js/lib/jquery.cookie.js
               [echo]   C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/js/lib/jquery.form.js
               [echo]   C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/js/lib/jquery.jstree.js
               [echo]   C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/js/lib/jquery.timeago.js
               [echo]   C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/js/lib/order.js
               [echo]   C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/js/require.js
          
          Show
          Uwe Schindler added a comment - The attached patch shows the problem, the following files have no license header and are also missing in NOTICE.txt (most of the files are 3rd party, so they must be listed with license in the NOTICE.txt): [echo] Unapproved licenses: [echo] [echo] C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/WEB-INF/weblogic.xml [echo] C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/css/chosen.css [echo] C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/css/styles/analysis.css [echo] C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/css/styles/cloud.css [echo] C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/css/styles/common.css [echo] C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/css/styles/cores.css [echo] C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/css/styles/dashboard.css [echo] C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/css/styles/dataimport.css [echo] C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/css/styles/documents.css [echo] C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/css/styles/index.css [echo] C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/css/styles/java-properties.css [echo] C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/css/styles/logging.css [echo] C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/css/styles/menu.css [echo] C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/css/styles/plugins.css [echo] C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/css/styles/query.css [echo] C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/css/styles/replication.css [echo] C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/css/styles/schema-browser.css [echo] C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/css/styles/threads.css [echo] C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/js/lib/ZeroClipboard.js [echo] C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/js/lib/chosen.js [echo] C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/js/lib/d3.js [echo] C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/js/lib/highlight.js [echo] C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/js/lib/jquery-1.7.2.min.js [echo] C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/js/lib/jquery.autogrow.js [echo] C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/js/lib/jquery.blockUI.js [echo] C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/js/lib/jquery.cookie.js [echo] C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/js/lib/jquery.form.js [echo] C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/js/lib/jquery.jstree.js [echo] C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/js/lib/jquery.timeago.js [echo] C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/js/lib/order.js [echo] C:/Users/Uwe Schindler/Projects/lucene/trunk-lusolr3/solr/webapp/web/js/require.js
          Hide
          Uwe Schindler added a comment -

          Simpler file pattern for $rat.additional-includes.

          Show
          Uwe Schindler added a comment - Simpler file pattern for $rat.additional-includes .
          Hide
          Uwe Schindler added a comment -

          This patch enables ant rat-sources to work on webapp module from root folder.

          Show
          Uwe Schindler added a comment - This patch enables ant rat-sources to work on webapp module from root folder.
          Hide
          Stefan Matheis (steffkes) added a comment -

          updated patch, includes license detection for highlight.js and d3.js

          Show
          Stefan Matheis (steffkes) added a comment - updated patch, includes license detection for highlight.js and d3.js
          Hide
          Stefan Matheis (steffkes) added a comment -

          Fixed all of them, no more cases w/o license:

                [rat] *****************************************************
                [rat]   Files with Apache License headers will be marked AL
                [rat]   Binary files (which do not require AL headers) will be marked B
                [rat]   Compressed archives will be marked A
                [rat]   Notices, licenses etc will be marked N
                [rat]   AL    /opt/solr/trunk/solr/webapp/build.xml
                [rat]   AL    /opt/solr/trunk/solr/webapp/web/WEB-INF/web.xml
                [rat]   AL    /opt/solr/trunk/solr/webapp/web/WEB-INF/weblogic.xml
                [rat]   AL    /opt/solr/trunk/solr/webapp/web/admin.html
                [rat]   MIT   /opt/solr/trunk/solr/webapp/web/css/chosen.css
                [rat]   AL    /opt/solr/trunk/solr/webapp/web/css/styles/analysis.css
                [rat]   AL    /opt/solr/trunk/solr/webapp/web/css/styles/cloud.css
                [rat]   AL    /opt/solr/trunk/solr/webapp/web/css/styles/common.css
                [rat]   AL    /opt/solr/trunk/solr/webapp/web/css/styles/cores.css
                [rat]   AL    /opt/solr/trunk/solr/webapp/web/css/styles/dashboard.css
                [rat]   AL    /opt/solr/trunk/solr/webapp/web/css/styles/dataimport.css
                [rat]   AL    /opt/solr/trunk/solr/webapp/web/css/styles/documents.css
                [rat]   AL    /opt/solr/trunk/solr/webapp/web/css/styles/index.css
                [rat]   AL    /opt/solr/trunk/solr/webapp/web/css/styles/java-properties.css
                [rat]   AL    /opt/solr/trunk/solr/webapp/web/css/styles/logging.css
                [rat]   AL    /opt/solr/trunk/solr/webapp/web/css/styles/menu.css
                [rat]   AL    /opt/solr/trunk/solr/webapp/web/css/styles/plugins.css
                [rat]   AL    /opt/solr/trunk/solr/webapp/web/css/styles/query.css
                [rat]   AL    /opt/solr/trunk/solr/webapp/web/css/styles/replication.css
                [rat]   AL    /opt/solr/trunk/solr/webapp/web/css/styles/schema-browser.css
                [rat]   AL    /opt/solr/trunk/solr/webapp/web/css/styles/threads.css
          ...
                [rat]   MIT   /opt/solr/trunk/solr/webapp/web/js/lib/ZeroClipboard.js
                [rat]   MIT   /opt/solr/trunk/solr/webapp/web/js/lib/chosen.js
                [rat]   AL    /opt/solr/trunk/solr/webapp/web/js/lib/console.js
                [rat]   BSD   /opt/solr/trunk/solr/webapp/web/js/lib/d3.js
                [rat]   BSD   /opt/solr/trunk/solr/webapp/web/js/lib/highlight.js
                [rat]   MIT   /opt/solr/trunk/solr/webapp/web/js/lib/jquery-1.7.2.min.js
                [rat]   MIT   /opt/solr/trunk/solr/webapp/web/js/lib/jquery.ajaxfileupload.js
                [rat]   MIT   /opt/solr/trunk/solr/webapp/web/js/lib/jquery.blockUI.js
                [rat]   MIT   /opt/solr/trunk/solr/webapp/web/js/lib/jquery.cookie.js
                [rat]   MIT   /opt/solr/trunk/solr/webapp/web/js/lib/jquery.form.js
                [rat]   MIT   /opt/solr/trunk/solr/webapp/web/js/lib/jquery.jstree.js
                [rat]   AL    /opt/solr/trunk/solr/webapp/web/js/lib/jquery.sammy.js
                [rat]   MIT   /opt/solr/trunk/solr/webapp/web/js/lib/jquery.timeago.js
                [rat]   MIT   /opt/solr/trunk/solr/webapp/web/js/lib/linker.js
                [rat]   MIT   /opt/solr/trunk/solr/webapp/web/js/lib/order.js
                [rat]   AL    /opt/solr/trunk/solr/webapp/web/js/main.js
                [rat]   MIT   /opt/solr/trunk/solr/webapp/web/js/require.js
          ...
          Show
          Stefan Matheis (steffkes) added a comment - Fixed all of them, no more cases w/o license: [rat] ***************************************************** [rat] Files with Apache License headers will be marked AL [rat] Binary files (which do not require AL headers) will be marked B [rat] Compressed archives will be marked A [rat] Notices, licenses etc will be marked N [rat] AL /opt/solr/trunk/solr/webapp/build.xml [rat] AL /opt/solr/trunk/solr/webapp/web/WEB-INF/web.xml [rat] AL /opt/solr/trunk/solr/webapp/web/WEB-INF/weblogic.xml [rat] AL /opt/solr/trunk/solr/webapp/web/admin.html [rat] MIT /opt/solr/trunk/solr/webapp/web/css/chosen.css [rat] AL /opt/solr/trunk/solr/webapp/web/css/styles/analysis.css [rat] AL /opt/solr/trunk/solr/webapp/web/css/styles/cloud.css [rat] AL /opt/solr/trunk/solr/webapp/web/css/styles/common.css [rat] AL /opt/solr/trunk/solr/webapp/web/css/styles/cores.css [rat] AL /opt/solr/trunk/solr/webapp/web/css/styles/dashboard.css [rat] AL /opt/solr/trunk/solr/webapp/web/css/styles/dataimport.css [rat] AL /opt/solr/trunk/solr/webapp/web/css/styles/documents.css [rat] AL /opt/solr/trunk/solr/webapp/web/css/styles/index.css [rat] AL /opt/solr/trunk/solr/webapp/web/css/styles/java-properties.css [rat] AL /opt/solr/trunk/solr/webapp/web/css/styles/logging.css [rat] AL /opt/solr/trunk/solr/webapp/web/css/styles/menu.css [rat] AL /opt/solr/trunk/solr/webapp/web/css/styles/plugins.css [rat] AL /opt/solr/trunk/solr/webapp/web/css/styles/query.css [rat] AL /opt/solr/trunk/solr/webapp/web/css/styles/replication.css [rat] AL /opt/solr/trunk/solr/webapp/web/css/styles/schema-browser.css [rat] AL /opt/solr/trunk/solr/webapp/web/css/styles/threads.css ... [rat] MIT /opt/solr/trunk/solr/webapp/web/js/lib/ZeroClipboard.js [rat] MIT /opt/solr/trunk/solr/webapp/web/js/lib/chosen.js [rat] AL /opt/solr/trunk/solr/webapp/web/js/lib/console.js [rat] BSD /opt/solr/trunk/solr/webapp/web/js/lib/d3.js [rat] BSD /opt/solr/trunk/solr/webapp/web/js/lib/highlight.js [rat] MIT /opt/solr/trunk/solr/webapp/web/js/lib/jquery-1.7.2.min.js [rat] MIT /opt/solr/trunk/solr/webapp/web/js/lib/jquery.ajaxfileupload.js [rat] MIT /opt/solr/trunk/solr/webapp/web/js/lib/jquery.blockUI.js [rat] MIT /opt/solr/trunk/solr/webapp/web/js/lib/jquery.cookie.js [rat] MIT /opt/solr/trunk/solr/webapp/web/js/lib/jquery.form.js [rat] MIT /opt/solr/trunk/solr/webapp/web/js/lib/jquery.jstree.js [rat] AL /opt/solr/trunk/solr/webapp/web/js/lib/jquery.sammy.js [rat] MIT /opt/solr/trunk/solr/webapp/web/js/lib/jquery.timeago.js [rat] MIT /opt/solr/trunk/solr/webapp/web/js/lib/linker.js [rat] MIT /opt/solr/trunk/solr/webapp/web/js/lib/order.js [rat] AL /opt/solr/trunk/solr/webapp/web/js/main.js [rat] MIT /opt/solr/trunk/solr/webapp/web/js/require.js ...
          Hide
          Stefan Matheis (steffkes) added a comment -

          Updated the Patch including mentions in NOTICE.txt

          Show
          Stefan Matheis (steffkes) added a comment - Updated the Patch including mentions in NOTICE.txt
          Hide
          Stefan Matheis (steffkes) added a comment -

          updated license on sammy.js

          Show
          Stefan Matheis (steffkes) added a comment - updated license on sammy.js
          Hide
          Uwe Schindler added a comment -

          I am fine with the patch! I think you can commit it!

          Show
          Uwe Schindler added a comment - I am fine with the patch! I think you can commit it!
          Hide
          Stefan Matheis (steffkes) added a comment -

          committed in ...
          trunk r1497311
          branch_4x r1497313

          Show
          Stefan Matheis (steffkes) added a comment - committed in ... trunk r1497311 branch_4x r1497313
          Hide
          The Heavy Commit Tag Bot added a comment -

          [trunk commit] uschindler
          http://svn.apache.org/viewvc?view=revision&revision=1497595

          SOLR-4966: Fix problem with binary detection in Apache Rat by excluding the images folder

          Show
          The Heavy Commit Tag Bot added a comment - [trunk commit] uschindler http://svn.apache.org/viewvc?view=revision&revision=1497595 SOLR-4966 : Fix problem with binary detection in Apache Rat by excluding the images folder
          Hide
          The Heavy Commit Tag Bot added a comment -

          [branch_4x commit] uschindler
          http://svn.apache.org/viewvc?view=revision&revision=1497596

          Merged revision(s) 1497595 from lucene/dev/trunk:
          SOLR-4966: Fix problem with binary detection in Apache Rat by excluding the images folder

          Show
          The Heavy Commit Tag Bot added a comment - [branch_4x commit] uschindler http://svn.apache.org/viewvc?view=revision&revision=1497596 Merged revision(s) 1497595 from lucene/dev/trunk: SOLR-4966 : Fix problem with binary detection in Apache Rat by excluding the images folder
          Hide
          Steve Rowe added a comment -

          Bulk close resolved 4.4 issues

          Show
          Steve Rowe added a comment - Bulk close resolved 4.4 issues

            People

            • Assignee:
              Stefan Matheis (steffkes)
              Reporter:
              Uwe Schindler
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development