Solr
  1. Solr
  2. SOLR-4953

Config XML parsing should fail hard if an xpath is expect to match at most one node/string/int/boolean and multiple values are found

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.5, Trunk
    • Component/s: None
    • Labels:
      None

      Description

      while reviewing some code i think i noticed that if there are multiple <indexConfig/> blocks in solrconfig.xml, one just "wins" and hte rest are ignored.

      this should be a hard failure situation, and we should have a "TestBadConfig" method to verify it.

      broadened goal of issue to fail if configuration contains multiple nodes/values for any option where only one value is expected.

      1. SOLR-4953.patch
        4 kB
        Hoss Man
      2. SOLR-4953.patch
        9 kB
        Hoss Man

        Issue Links

          Activity

          Hoss Man created issue -
          Hoss Man made changes -
          Field Original Value New Value
          Link This issue blocks SOLR-4950 [ SOLR-4950 ]
          Hoss Man made changes -
          Attachment SOLR-4953.patch [ 12594633 ]
          Hoss Man made changes -
          Attachment SOLR-4953.patch [ 12594801 ]
          Hoss Man made changes -
          Summary solrconfig.xml parsing should fail hard if there are multiple <indexConfig/> blocks Config XML parsing should fail hard if an xpath is expect to match at most one node/string/int/boolean and multiple values are found
          Issue Type Bug [ 1 ] Improvement [ 4 ]
          Description while reviewing some code i think i noticed that if there are multiple {{<indexConfig/>}} blocks in solrconfig.xml, one just "wins" and hte rest are ignored.

          this should be a hard failure situation, and we should have a "TestBadConfig" method to verify it.
          while reviewing some code i think i noticed that if there are multiple {{<indexConfig/>}} blocks in solrconfig.xml, one just "wins" and hte rest are ignored.

          this should be a hard failure situation, and we should have a "TestBadConfig" method to verify it.

          ---

          broadened goal of issue to fail if configuration contains multiple nodes/values for any option where only one value is expected.
          Hoss Man made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s 4.5 [ 12324743 ]
          Fix Version/s 5.0 [ 12321664 ]
          Resolution Fixed [ 1 ]
          Adrien Grand made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Shalin Shekhar Mangar made changes -
          Link This issue is duplicated by SOLR-6201 [ SOLR-6201 ]

            People

            • Assignee:
              Hoss Man
              Reporter:
              Hoss Man
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development