Solr
  1. Solr
  2. SOLR-4950 beter randomized testing of <indexConfig> settings
  3. SOLR-4952

audit test configs to use solrconfig.snippet.randomindexconfig.xml in more tests

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.5, Trunk
    • Component/s: None
    • Labels:
      None

      Description

      in SOLR-4942 i updated every solrconfig.xml to either...

      • include solrconfig.snippet.randomindexconfig.xml where it was easy to do so
      • use the useCompoundFile sys prop if it already had an <indexConfig> section, or if including the snippet wasn't going to be easy (ie: contrib tests)

      As an improvment on this:

      • audit all core configs not already using solrconfig.snippet.randomindexconfig.xml and either:
        • make them use it, ignoring any previously unimportant explicit incdexConfig settings
        • make them use it, using explicit sys props to overwrite random values in cases were explicit indexConfig values are important for test
        • add a comment why it's not using the include snippet in cases where the explicit parsing is part of hte test

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          53d 18h 22m 1 Hoss Man 14/Aug/13 19:22
          Resolved Resolved Closed Closed
          51d 15h 56m 1 Adrien Grand 05/Oct/13 11:19
          Adrien Grand made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          Adrien Grand added a comment -

          4.5 release -> bulk close

          Show
          Adrien Grand added a comment - 4.5 release -> bulk close
          Hide
          ASF subversion and git services added a comment -

          Commit 1514404 from hossman@apache.org in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1514404 ]

          SOLR-4952: SolrCmdDistributorTest needs to force MergePolicy for consistent optimize() behavior (merge r1514377)

          Show
          ASF subversion and git services added a comment - Commit 1514404 from hossman@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1514404 ] SOLR-4952 : SolrCmdDistributorTest needs to force MergePolicy for consistent optimize() behavior (merge r1514377)
          Hide
          ASF subversion and git services added a comment -

          Commit 1514377 from hossman@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1514377 ]

          SOLR-4952: SolrCmdDistributorTest needs to force MergePolicy for consistent optimize() behavior

          Show
          ASF subversion and git services added a comment - Commit 1514377 from hossman@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1514377 ] SOLR-4952 : SolrCmdDistributorTest needs to force MergePolicy for consistent optimize() behavior
          Hoss Man made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s 4.5 [ 12324743 ]
          Fix Version/s 5.0 [ 12321664 ]
          Resolution Fixed [ 1 ]
          Hide
          Hoss Man added a comment -

          Done, and done ... WOOT!

          Show
          Hoss Man added a comment - Done, and done ... WOOT!
          Hide
          ASF subversion and git services added a comment -

          Commit 1514001 from hossman@apache.org in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1514001 ]

          cleanup TestSolrCoreProperties so that it's less hackish and absurd – and while we're at it, close the book on SOLR-4952 (merge r1513996)

          Show
          ASF subversion and git services added a comment - Commit 1514001 from hossman@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1514001 ] cleanup TestSolrCoreProperties so that it's less hackish and absurd – and while we're at it, close the book on SOLR-4952 (merge r1513996)
          Hide
          ASF subversion and git services added a comment -

          Commit 1513996 from hossman@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1513996 ]

          cleanup TestSolrCoreProperties so that it's less hackish and absurd – and while we're at it, close the book on SOLR-4952

          Show
          ASF subversion and git services added a comment - Commit 1513996 from hossman@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1513996 ] cleanup TestSolrCoreProperties so that it's less hackish and absurd – and while we're at it, close the book on SOLR-4952
          Hoss Man made changes -
          Description in SOLR-4942 i updated every solrconfig.xml to either...

          * include solrconfig.snippet.randomindexconfig.xml where it was easy to do so
          * use the useCompoundFile sys prop if it already had an {{<indexConfig>}} section, or if including the snippet wasn't going to be easy (ie: contrib tests)

          As an improvment on this:

          * audit all core configs not already using solrconfig.snippet.randomindexconfig.xml and either:
          ** make them use it, ignoring any previously unimportant explicit incdexConfig settings
          ** make them use it, using explicit sys props to overwrite random values in cases were explicit indexConfig values are important for test
          ** add a comment why it's not using the include snippet in cases where the explicit parsing is part of hte test
          * try figure out a way for contrib tests to easily include the same file and/or apply the same rules as above
          in SOLR-4942 i updated every solrconfig.xml to either...

          * include solrconfig.snippet.randomindexconfig.xml where it was easy to do so
          * use the useCompoundFile sys prop if it already had an {{<indexConfig>}} section, or if including the snippet wasn't going to be easy (ie: contrib tests)

          As an improvment on this:

          * audit all core configs not already using solrconfig.snippet.randomindexconfig.xml and either:
          ** make them use it, ignoring any previously unimportant explicit incdexConfig settings
          ** make them use it, using explicit sys props to overwrite random values in cases were explicit indexConfig values are important for test
          ** add a comment why it's not using the include snippet in cases where the explicit parsing is part of hte test
          Hide
          Hoss Man added a comment -

          dealing with contrib tests is going to be a bit tricky, so splitting that out into it's own issue: SOLR-5155

          Show
          Hoss Man added a comment - dealing with contrib tests is going to be a bit tricky, so splitting that out into it's own issue: SOLR-5155
          Hide
          ASF subversion and git services added a comment -

          Commit 1513698 from hossman@apache.org in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1513698 ]

          SOLR-4952: solrconfig.snippet.randomindexconfig.xml used in more configs, including eliminating TestPluginEnable and folding it into TestConfig (merge r1513691)

          Show
          ASF subversion and git services added a comment - Commit 1513698 from hossman@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1513698 ] SOLR-4952 : solrconfig.snippet.randomindexconfig.xml used in more configs, including eliminating TestPluginEnable and folding it into TestConfig (merge r1513691)
          Hide
          ASF subversion and git services added a comment -

          Commit 1513691 from hossman@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1513691 ]

          SOLR-4952: solrconfig.snippet.randomindexconfig.xml used in more configs, including eliminating TestPluginEnable and folding it into TestConfig

          Show
          ASF subversion and git services added a comment - Commit 1513691 from hossman@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1513691 ] SOLR-4952 : solrconfig.snippet.randomindexconfig.xml used in more configs, including eliminating TestPluginEnable and folding it into TestConfig
          Hide
          ASF subversion and git services added a comment -

          Commit 1513616 from hossman@apache.org in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1513616 ]

          SOLR-4952: get all manged schema tests using solrconfig.snippet.randomindexconfig.xml - mainly by removing several solrconfig-*-managed-schema.xml files and using sys props in solrconfig-managed-schema.xml (merge r1513611)

          Show
          ASF subversion and git services added a comment - Commit 1513616 from hossman@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1513616 ] SOLR-4952 : get all manged schema tests using solrconfig.snippet.randomindexconfig.xml - mainly by removing several solrconfig-*-managed-schema.xml files and using sys props in solrconfig-managed-schema.xml (merge r1513611)
          Hide
          ASF subversion and git services added a comment -

          Commit 1513611 from hossman@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1513611 ]

          SOLR-4952: get all manged schema tests using solrconfig.snippet.randomindexconfig.xml - mainly by removing several solrconfig-*-managed-schema.xml files and using sys props in solrconfig-managed-schema.xml

          Show
          ASF subversion and git services added a comment - Commit 1513611 from hossman@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1513611 ] SOLR-4952 : get all manged schema tests using solrconfig.snippet.randomindexconfig.xml - mainly by removing several solrconfig-*-managed-schema.xml files and using sys props in solrconfig-managed-schema.xml
          Hide
          ASF subversion and git services added a comment -

          Commit 1513587 from hossman@apache.org in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1513587 ]

          SOLR-4952: use solrconfig.snippet.randomindexconfig.xml in the QueryElevation tests (merge r1513586)

          Show
          ASF subversion and git services added a comment - Commit 1513587 from hossman@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1513587 ] SOLR-4952 : use solrconfig.snippet.randomindexconfig.xml in the QueryElevation tests (merge r1513586)
          Hide
          ASF subversion and git services added a comment -

          Commit 1513586 from hossman@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1513586 ]

          SOLR-4952: use solrconfig.snippet.randomindexconfig.xml in the QueryElevation tests

          Show
          ASF subversion and git services added a comment - Commit 1513586 from hossman@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1513586 ] SOLR-4952 : use solrconfig.snippet.randomindexconfig.xml in the QueryElevation tests
          Hide
          ASF subversion and git services added a comment -

          Commit 1513325 from hossman@apache.org in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1513325 ]

          SOLR-4952: make TestConfig use solrconfig.snippet.randomindexconfig.xml - this involved moving some 'default' tests arround, prunning down solrconfig-termindex.xml, and renaming solrconfig-termindex.xml -> solrconfig-test-misc.xml since the name 'termindex' no longer makes sense (merge r1513312)

          Show
          ASF subversion and git services added a comment - Commit 1513325 from hossman@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1513325 ] SOLR-4952 : make TestConfig use solrconfig.snippet.randomindexconfig.xml - this involved moving some 'default' tests arround, prunning down solrconfig-termindex.xml, and renaming solrconfig-termindex.xml -> solrconfig-test-misc.xml since the name 'termindex' no longer makes sense (merge r1513312)
          Hide
          ASF subversion and git services added a comment -

          Commit 1513312 from hossman@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1513312 ]

          SOLR-4952: make TestConfig use solrconfig.snippet.randomindexconfig.xml - this involved moving some 'default' tests arround, prunning down solrconfig-termindex.xml, and renaming solrconfig-termindex.xml -> solrconfig-test-misc.xml since the mane 'termindex' made no sense for what it is used for

          Show
          ASF subversion and git services added a comment - Commit 1513312 from hossman@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1513312 ] SOLR-4952 : make TestConfig use solrconfig.snippet.randomindexconfig.xml - this involved moving some 'default' tests arround, prunning down solrconfig-termindex.xml, and renaming solrconfig-termindex.xml -> solrconfig-test-misc.xml since the mane 'termindex' made no sense for what it is used for
          Hoss Man made changes -
          Link This issue breaks SOLR-5140 [ SOLR-5140 ]
          Hide
          ASF subversion and git services added a comment -

          Commit 1511958 from hossman@apache.org in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1511958 ]

          SOLR-4952: TestIndexSearcher.testReopen needs fixed segment merging (merge r1511954)

          Show
          ASF subversion and git services added a comment - Commit 1511958 from hossman@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1511958 ] SOLR-4952 : TestIndexSearcher.testReopen needs fixed segment merging (merge r1511954)
          Hide
          ASF subversion and git services added a comment -

          Commit 1511954 from hossman@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1511954 ]

          SOLR-4952: TestIndexSearcher.testReopen needs fixed segment merging

          Show
          ASF subversion and git services added a comment - Commit 1511954 from hossman@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1511954 ] SOLR-4952 : TestIndexSearcher.testReopen needs fixed segment merging
          Hoss Man made changes -
          Field Original Value New Value
          Link This issue is related to SOLR-5122 [ SOLR-5122 ]
          Hide
          ASF subversion and git services added a comment -

          Commit 1511139 from hossman@apache.org in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1511139 ]

          SOLR-4952: TestSolrDeletionPolicy2 can't directly use solrconfig.snippet.randomindexconfig.xml - but it can leverage the random sys props directly

          Show
          ASF subversion and git services added a comment - Commit 1511139 from hossman@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1511139 ] SOLR-4952 : TestSolrDeletionPolicy2 can't directly use solrconfig.snippet.randomindexconfig.xml - but it can leverage the random sys props directly
          Hide
          ASF subversion and git services added a comment -

          Commit 1511138 from hossman@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1511138 ]

          SOLR-4952: TestSolrDeletionPolicy2 can't directly use solrconfig.snippet.randomindexconfig.xml - but it can leverage the random sys props directly

          Show
          ASF subversion and git services added a comment - Commit 1511138 from hossman@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1511138 ] SOLR-4952 : TestSolrDeletionPolicy2 can't directly use solrconfig.snippet.randomindexconfig.xml - but it can leverage the random sys props directly
          Hide
          ASF subversion and git services added a comment -

          Commit 1511137 from hossman@apache.org in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1511137 ]

          SOLR-4952: get SolrCoreCheckLockOnStartupTest using solrconfig.snippet.randomindexconfig.xml (merge r1511134)

          Show
          ASF subversion and git services added a comment - Commit 1511137 from hossman@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1511137 ] SOLR-4952 : get SolrCoreCheckLockOnStartupTest using solrconfig.snippet.randomindexconfig.xml (merge r1511134)
          Hide
          ASF subversion and git services added a comment -

          Commit 1511134 from hossman@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1511134 ]

          SOLR-4952: get SolrCoreCheckLockOnStartupTest using solrconfig.snippet.randomindexconfig.xml

          Show
          ASF subversion and git services added a comment - Commit 1511134 from hossman@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1511134 ] SOLR-4952 : get SolrCoreCheckLockOnStartupTest using solrconfig.snippet.randomindexconfig.xml
          Hide
          ASF subversion and git services added a comment -

          Commit 1511129 from hossman@apache.org in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1511129 ]

          SOLR-4952: TestSolrDeletionPolicy1 can't directly use solrconfig.snippet.randomindexconfig.xml - but it can leverage the random sys props directly (merge r1511128)

          Show
          ASF subversion and git services added a comment - Commit 1511129 from hossman@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1511129 ] SOLR-4952 : TestSolrDeletionPolicy1 can't directly use solrconfig.snippet.randomindexconfig.xml - but it can leverage the random sys props directly (merge r1511128)
          Hide
          ASF subversion and git services added a comment -

          Commit 1511128 from hossman@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1511128 ]

          SOLR-4952: TestSolrDeletionPolicy1 can't directly use solrconfig.snippet.randomindexconfig.xml - but it can leverage the random sys props directly

          Show
          ASF subversion and git services added a comment - Commit 1511128 from hossman@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1511128 ] SOLR-4952 : TestSolrDeletionPolicy1 can't directly use solrconfig.snippet.randomindexconfig.xml - but it can leverage the random sys props directly
          Hide
          ASF subversion and git services added a comment -

          Commit 1511126 from hossman@apache.org in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1511126 ]

          SOLR-4952: missed the repeater config used in TestReplicationHandler (merge r1511123)

          Show
          ASF subversion and git services added a comment - Commit 1511126 from hossman@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1511126 ] SOLR-4952 : missed the repeater config used in TestReplicationHandler (merge r1511123)
          Hide
          ASF subversion and git services added a comment -

          Commit 1511123 from hossman@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1511123 ]

          SOLR-4952: missed the repeater config used in TestReplicationHandler

          Show
          ASF subversion and git services added a comment - Commit 1511123 from hossman@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1511123 ] SOLR-4952 : missed the repeater config used in TestReplicationHandler
          Hide
          ASF subversion and git services added a comment -

          Commit 1511046 from hossman@apache.org in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1511046 ]

          SOLR-4952: ConvertedLegacyTest shouldn't assuming an absolute score now that we are randomizing merge policy settings, term stats may fluctuate (merge r1511044)

          Show
          ASF subversion and git services added a comment - Commit 1511046 from hossman@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1511046 ] SOLR-4952 : ConvertedLegacyTest shouldn't assuming an absolute score now that we are randomizing merge policy settings, term stats may fluctuate (merge r1511044)
          Hide
          ASF subversion and git services added a comment -

          Commit 1511044 from hossman@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1511044 ]

          SOLR-4952: ConvertedLegacyTest shouldn't assuming an absolute score now that we are randomizing merge policy settings, term stats may fluctuate

          Show
          ASF subversion and git services added a comment - Commit 1511044 from hossman@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1511044 ] SOLR-4952 : ConvertedLegacyTest shouldn't assuming an absolute score now that we are randomizing merge policy settings, term stats may fluctuate
          Hide
          ASF subversion and git services added a comment -

          Commit 1510854 from hossman@apache.org in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1510854 ]

          SOLR-4952: fix DirectUpdateHandlerTest, it can't handle RandomMergePolicy (merge r1510853)

          Show
          ASF subversion and git services added a comment - Commit 1510854 from hossman@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1510854 ] SOLR-4952 : fix DirectUpdateHandlerTest, it can't handle RandomMergePolicy (merge r1510853)
          Hide
          ASF subversion and git services added a comment -

          Commit 1510853 from hossman@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1510853 ]

          SOLR-4952: fix DirectUpdateHandlerTest, it can't handle RandomMergePolicy

          Show
          ASF subversion and git services added a comment - Commit 1510853 from hossman@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1510853 ] SOLR-4952 : fix DirectUpdateHandlerTest, it can't handle RandomMergePolicy
          Hide
          ASF subversion and git services added a comment -

          Commit 1510845 from hossman@apache.org in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1510845 ]

          SOLR-4952: get TestReplicationHandler using solrconfig.snippet.randomindexconfig.xml. This also fixes NumericFieldsTest and TestBinaryField which were using the replication configs for no explicable reason, and since i needed to fix TestBinaryField anyway, i simplified it to use SolrJettyTestBase instead of it's own kludgy setup (merge r1510838)

          Show
          ASF subversion and git services added a comment - Commit 1510845 from hossman@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1510845 ] SOLR-4952 : get TestReplicationHandler using solrconfig.snippet.randomindexconfig.xml. This also fixes NumericFieldsTest and TestBinaryField which were using the replication configs for no explicable reason, and since i needed to fix TestBinaryField anyway, i simplified it to use SolrJettyTestBase instead of it's own kludgy setup (merge r1510838)
          Hide
          ASF subversion and git services added a comment -

          Commit 1510838 from hossman@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1510838 ]

          SOLR-4952: get TestReplicationHandler using solrconfig.snippet.randomindexconfig.xml. This also fixes NumericFieldsTest and TestBinaryField which were using the replication configs for no explicable reason, and since i needed to fix TestBinaryField anyway, i simplified it to use SolrJettyTestBase instead of it's own kludgy setup

          Show
          ASF subversion and git services added a comment - Commit 1510838 from hossman@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1510838 ] SOLR-4952 : get TestReplicationHandler using solrconfig.snippet.randomindexconfig.xml. This also fixes NumericFieldsTest and TestBinaryField which were using the replication configs for no explicable reason, and since i needed to fix TestBinaryField anyway, i simplified it to use SolrJettyTestBase instead of it's own kludgy setup
          Hide
          ASF subversion and git services added a comment -

          Commit 1510817 from hossman@apache.org in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1510817 ]

          SOLR-4952: use solrconfig.snippet.randomindexconfig.xml in solrconfig.xml and crazy-path-to-config.xml; this included removing some unneccessary checks for indexConfig settings that already have their own explicit tests (merge r1510802)

          Show
          ASF subversion and git services added a comment - Commit 1510817 from hossman@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1510817 ] SOLR-4952 : use solrconfig.snippet.randomindexconfig.xml in solrconfig.xml and crazy-path-to-config.xml; this included removing some unneccessary checks for indexConfig settings that already have their own explicit tests (merge r1510802)
          Hide
          ASF subversion and git services added a comment -

          Commit 1510802 from hossman@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1510802 ]

          SOLR-4952: use solrconfig.snippet.randomindexconfig.xml in solrconfig.xml and crazy-path-to-config.xml; this included removing some unneccessary checks for indexConfig settings that already have their own explicit tests

          Show
          ASF subversion and git services added a comment - Commit 1510802 from hossman@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1510802 ] SOLR-4952 : use solrconfig.snippet.randomindexconfig.xml in solrconfig.xml and crazy-path-to-config.xml; this included removing some unneccessary checks for indexConfig settings that already have their own explicit tests
          Hoss Man created issue -

            People

            • Assignee:
              Hoss Man
              Reporter:
              Hoss Man
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development