Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-4948

Tidy up CoreContainer construction logic

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.4
    • Component/s: None
    • Labels:
      None

      Description

      While writing tests for SOLR-4914, I discovered that it's really difficult to create a CoreContainer. There are a bunch of constructors which initialise different things, one (but only one!) of which also loads all the cores. Then you have the Initializer object, which basically does the same thing. Sort of. And then the TestHarness doesn't actually use CoreContainer, but an anonymous subclass of CoreContainer which has it's own initialisation logic. It would be nice to clean this up!

        Attachments

        1. SOLR-4948.patch
          126 kB
          Alan Woodward
        2. SOLR-4948.patch
          123 kB
          Alan Woodward
        3. SOLR-4948.patch
          112 kB
          Alan Woodward
        4. SOLR-4948.patch
          108 kB
          Alan Woodward
        5. SOLR-4948.patch
          88 kB
          Alan Woodward
        6. SOLR-4948.patch
          86 kB
          Alan Woodward
        7. SOLR-4948.patch
          80 kB
          Alan Woodward

          Issue Links

            Activity

              People

              • Assignee:
                romseygeek Alan Woodward
                Reporter:
                romseygeek Alan Woodward
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: