[SOLR-4948] Tidy up CoreContainer construction logic

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 4.4
• Assignee: Alan Woodward
• Reporter: Alan Woodward
• Created: 21/Jun/13 15:25
• Updated: 15/Aug/13 05:23
• Resolved: 06/Jul/13 19:29

Description

While writing tests for SOLR-4914, I discovered that it's really difficult to create a CoreContainer. There are a bunch of constructors which initialise different things, one (but only one!) of which also loads all the cores. Then you have the Initializer object, which basically does the same thing. Sort of. And then the TestHarness doesn't actually use CoreContainer, but an anonymous subclass of CoreContainer which has it's own initialisation logic. It would be nice to clean this up!

Issue Links

• breaks: SOLR-5009 CoreContainer instantiates 2 SolrResourceLoaders (implicit) but does not close all of them
• is depended upon by: SOLR-4982 Creating a core while referencing system properties looks like it loses files.
• is related to: SOLR-5011 Manage to close all ResourceLoaders when cores are unloaded/reloaded