Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-4934

Prevent runtime failure if users use initargs "useCompoundFile" setting on LogMergePolicy or TieredMergePolicy

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 4.4, 6.0
    • None
    • None

    Description

      • LUCENE-5038 eliminated setUseCompoundFile(boolean) from the built in MergePolicies
      • existing users may have configs that use <mergePolicy> init args to try and call that setter
      • we already do some explicit checks for these MergePolices in SolrIndexConfig to deal with legacy syntax
      • update the existing logic to remove "useCompoundFile" from the MergePolicy initArgs for these known policies if found, and log a warning.

      (NOTE: i don't want to arbitrarily remove "useCompoundFile" from the initArgs regardless of class in case someone has a custom MergePolicy that implements that logic – that would suck)

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            hossman Chris M. Hostetter
            hossman Chris M. Hostetter
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment