Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-4895

Throw an error when a rollback is attempted in SolrCloud mode.

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0, 6.0
    • Component/s: SolrCloud
    • Labels:
      None
    1. SOLR-4895.patch
      0.8 kB
      Vamsee Yarlagadda
    2. SOLR-4895-v2.patch
      0.7 kB
      Vamsee Yarlagadda

      Issue Links

        Activity

        Hide
        markrmiller@gmail.com Mark Miller added a comment -

        This is just an issue to explore this - it may mean we support it in solrcloud by throwing an unsupported operation exception

        Some of the current basic limiations:

        1. tlog is not hooked up to rollback
        2. rollback cmd is not distributed
        3. tlog wants an auto hard commit but this does not jive with rollback.

        Show
        markrmiller@gmail.com Mark Miller added a comment - This is just an issue to explore this - it may mean we support it in solrcloud by throwing an unsupported operation exception Some of the current basic limiations: 1. tlog is not hooked up to rollback 2. rollback cmd is not distributed 3. tlog wants an auto hard commit but this does not jive with rollback.
        Hide
        markrmiller@gmail.com Mark Miller added a comment -

        Comment from yonik in SOLR-4733:

        wrt cloud mode, there's probably a lot of edge cases we haven't considered when rollbacks come into play... peer sync stuff, recovery using whole index replication and then getting a rollback in the middle of buffering updates, etc.

        Show
        markrmiller@gmail.com Mark Miller added a comment - Comment from yonik in SOLR-4733 : wrt cloud mode, there's probably a lot of edge cases we haven't considered when rollbacks come into play... peer sync stuff, recovery using whole index replication and then getting a rollback in the middle of buffering updates, etc.
        Hide
        markrmiller@gmail.com Mark Miller added a comment -

        Given these challenges, I think we will end up having to throw an exception about not supporting rollback.

        Show
        markrmiller@gmail.com Mark Miller added a comment - Given these challenges, I think we will end up having to throw an exception about not supporting rollback.
        Hide
        steve_rowe Steve Rowe added a comment -

        Bulk move 4.4 issues to 4.5 and 5.0

        Show
        steve_rowe Steve Rowe added a comment - Bulk move 4.4 issues to 4.5 and 5.0
        Hide
        thetaphi Uwe Schindler added a comment -

        Move issue to Solr 4.9.

        Show
        thetaphi Uwe Schindler added a comment - Move issue to Solr 4.9.
        Hide
        vamsee Vamsee Yarlagadda added a comment -

        Just wondering, what would be a good way to know (code wise) which mode is the Solr running on? Cloud or Standalone?

        Logically, if we are using ZooKeeper then we can assume it is running in SolrCloud mode. But, if we are dealing with classes like RequestHandlerUtils (org.apache.solr.handler) which is more generic in nature, how do we figure out the mode of Solr?

        Show
        vamsee Vamsee Yarlagadda added a comment - Just wondering, what would be a good way to know (code wise) which mode is the Solr running on? Cloud or Standalone? Logically, if we are using ZooKeeper then we can assume it is running in SolrCloud mode. But, if we are dealing with classes like RequestHandlerUtils (org.apache.solr.handler) which is more generic in nature, how do we figure out the mode of Solr?
        Show
        markrmiller@gmail.com Mark Miller added a comment - Usually, http://lucene.apache.org/solr/4_9_0/solr-core/org/apache/solr/core/CoreContainer.html#isZooKeeperAware( )
        Hide
        vamsee Vamsee Yarlagadda added a comment -

        Sorry for the late response Mark Miller. Here is the patch for throwing out an error if rollback is called.

        Show
        vamsee Vamsee Yarlagadda added a comment - Sorry for the late response Mark Miller . Here is the patch for throwing out an error if rollback is called.
        Hide
        markrmiller@gmail.com Mark Miller added a comment -

        Thanks Vamsee. I wonder if we should put this in the updateHandler instead? Technically, RunUpdateProcessor is simply an optional part of the update chain, but we can be more sure that any SolrCloud external rollback will hit DirectUpdateHandler2#rollback.

        Show
        markrmiller@gmail.com Mark Miller added a comment - Thanks Vamsee. I wonder if we should put this in the updateHandler instead? Technically, RunUpdateProcessor is simply an optional part of the update chain, but we can be more sure that any SolrCloud external rollback will hit DirectUpdateHandler2#rollback.
        Hide
        vamsee Vamsee Yarlagadda added a comment -

        You are right, Mark.

        Moved the functionality to DirectUpdateHandler2 as processors can be skipped unless they implement UpdateRequestProcessorFactory.RunAlways

        Show
        vamsee Vamsee Yarlagadda added a comment - You are right, Mark. Moved the functionality to DirectUpdateHandler2 as processors can be skipped unless they implement UpdateRequestProcessorFactory.RunAlways
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1619637 from Mark Miller in branch 'dev/trunk'
        [ https://svn.apache.org/r1619637 ]

        SOLR-4895: An error should be returned when a rollback is attempted in SolrCloud mode.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1619637 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1619637 ] SOLR-4895 : An error should be returned when a rollback is attempted in SolrCloud mode.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1619638 from Mark Miller in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1619638 ]

        SOLR-4895: An error should be returned when a rollback is attempted in SolrCloud mode.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1619638 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1619638 ] SOLR-4895 : An error should be returned when a rollback is attempted in SolrCloud mode.
        Hide
        markrmiller@gmail.com Mark Miller added a comment -

        Thanks Vamsee!

        Show
        markrmiller@gmail.com Mark Miller added a comment - Thanks Vamsee!
        Hide
        anshumg Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        anshumg Anshum Gupta added a comment - Bulk close after 5.0 release.

          People

          • Assignee:
            markrmiller@gmail.com Mark Miller
            Reporter:
            markrmiller@gmail.com Mark Miller
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development