Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-4868

Log4J watcher - setting the root logger adds a logger for the empty string

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 4.3
    • Fix Version/s: 4.3.1, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      Root cause for SOLR-4867. Trying to set the root logging category results in the addition of a category that's the empty string.

      1. SOLR-4868.patch
        1 kB
        Shawn Heisey

        Issue Links

          Activity

          Hide
          elyograg Shawn Heisey added a comment -

          Patch to fix the issue. Shalin Shekhar Mangar, the CHANGES.txt entry is under 4.3.1, so I'd like to know whether it's OK to backport. If not, I'll move that to 4.4.

          Show
          elyograg Shawn Heisey added a comment - Patch to fix the issue. Shalin Shekhar Mangar , the CHANGES.txt entry is under 4.3.1, so I'd like to know whether it's OK to backport. If not, I'll move that to 4.4.
          Hide
          elyograg Shawn Heisey added a comment -

          Something related, not sure whether it's worth fixing: If you change the logging level to WARN (or below) on something low level like org (or the root, after this patch), you don't get anything in the log about changing the level - because the log entry about the change is INFO.

          Show
          elyograg Shawn Heisey added a comment - Something related, not sure whether it's worth fixing: If you change the logging level to WARN (or below) on something low level like org (or the root, after this patch), you don't get anything in the log about changing the level - because the log entry about the change is INFO.
          Hide
          hossman Hoss Man added a comment -

          +1 - patch looks clean and correct to me.

          As discussed with shawn on IRC, JulWatcher has similar code, but that seems to be correct - most likely this bug stemmed from the JulWatcher code being copied/modified to create the Log4jWatcher

          Show
          hossman Hoss Man added a comment - +1 - patch looks clean and correct to me. As discussed with shawn on IRC, JulWatcher has similar code, but that seems to be correct - most likely this bug stemmed from the JulWatcher code being copied/modified to create the Log4jWatcher
          Hide
          shalinmangar Shalin Shekhar Mangar added a comment -

          Shawn Heisey – Go ahead and backport it.

          Show
          shalinmangar Shalin Shekhar Mangar added a comment - Shawn Heisey – Go ahead and backport it.
          Hide
          elyograg Shawn Heisey added a comment -

          Committed.
          trunk: r1487294
          branch_4x: r1487319
          lucene_solr_4_3: r1487325

          Show
          elyograg Shawn Heisey added a comment - Committed. trunk: r1487294 branch_4x: r1487319 lucene_solr_4_3: r1487325
          Hide
          shalinmangar Shalin Shekhar Mangar added a comment -

          Bulk close after 4.3.1 release

          Show
          shalinmangar Shalin Shekhar Mangar added a comment - Bulk close after 4.3.1 release

            People

            • Assignee:
              elyograg Shawn Heisey
              Reporter:
              elyograg Shawn Heisey
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development