Solr
  1. Solr
  2. SOLR-4778

Move LogWatcher initialization code out of CoreContainer

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.4, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      CoreContainer.load is a bit scary. We can simplify it a bit by moving the LogWatcher initialization code into LogWatcher itself, which is where is belongs really.

      1. SOLR-4778.patch
        15 kB
        Alan Woodward
      2. SOLR-4778.patch
        15 kB
        Alan Woodward

        Activity

        Hide
        Alan Woodward added a comment -

        Patch. All tests pass, although I'm not convinced we have much coverage here.

        Show
        Alan Woodward added a comment - Patch. All tests pass, although I'm not convinced we have much coverage here.
        Hide
        Mark Miller added a comment -

        +1

        I'm not convinced we have much coverage here.

        I don't think we have tests for this LogWatcher stuff other than manually checking it in the UI do we?

        Show
        Mark Miller added a comment - +1 I'm not convinced we have much coverage here. I don't think we have tests for this LogWatcher stuff other than manually checking it in the UI do we?
        Hide
        Alan Woodward added a comment -

        New patch, with a simple logging test for log4j.

        Show
        Alan Woodward added a comment - New patch, with a simple logging test for log4j.
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] romseygeek
        http://svn.apache.org/viewvc?view=revision&revision=1478152

        SOLR-4778: Move LogWatcher init code out of CoreContainer

        Show
        Commit Tag Bot added a comment - [trunk commit] romseygeek http://svn.apache.org/viewvc?view=revision&revision=1478152 SOLR-4778 : Move LogWatcher init code out of CoreContainer
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] romseygeek
        http://svn.apache.org/viewvc?view=revision&revision=1478161

        SOLR-4778: Move LogWatcher init code out of CoreContainer

        Show
        Commit Tag Bot added a comment - [branch_4x commit] romseygeek http://svn.apache.org/viewvc?view=revision&revision=1478161 SOLR-4778 : Move LogWatcher init code out of CoreContainer
        Hide
        Steve Rowe added a comment -

        Bulk close resolved 4.4 issues

        Show
        Steve Rowe added a comment - Bulk close resolved 4.4 issues

          People

          • Assignee:
            Unassigned
            Reporter:
            Alan Woodward
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development