Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-4768

The Solr war produced by generate-maven-artifacts should not contain logging jars

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 4.3
    • Fix Version/s: 4.3, 6.0
    • Component/s: Build
    • Labels:
      None

      Description

      I know why the two .wars are different:

      The binary package Solr war's target chain is:

      'package'->'create-package'->'dist'->'dist-war'->webapp:'dist'

      The maven Solr war's target chain is:

      'generate-maven-artifacts'->webapp:'dist-maven'->webapp:'dist'

      So both create the war using webapp:'dist', but only 'dist-war' passes in a modified 'exclude.from.war' property definition (which is empty by default):

      <property name="exclude.from.war" value="*slf4j*,log4j-*" />

      As a result, the maven Solr war contains logging jars while the official war does not.

      I think the fix is to make the above the default setting, rather than passing in a non-default property value from 'dist-war'.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                sarowe Steven Rowe
                Reporter:
                sarowe Steven Rowe
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: