Solr
  1. Solr
  2. SOLR-4761

add option to plug in mergedsegmentwarmer

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.4, 5.0
    • Component/s: None
    • Labels:
      None

      Description

      This is pretty expert, but can be useful in some cases.

      We can also provide a simple minimalist implementation that just ensures datastructures are primed so the first queries aren't e.g. causing norms to be read from disk etc.

      1. SOLR-4761.patch
        9 kB
        Robert Muir
      2. SOLR-4761.patch
        13 kB
        Robert Muir

        Activity

        Hide
        Robert Muir added a comment -

        One confusing thing is that I think it won't actually kick in until after the first reopen. Thats because Solr first opens from the Directory directly, then from the writer in the NRT case...

        Seems like this would be good to fix, but we can still make progress on this issue in spite of it.

        Show
        Robert Muir added a comment - One confusing thing is that I think it won't actually kick in until after the first reopen. Thats because Solr first opens from the Directory directly, then from the writer in the NRT case... Seems like this would be good to fix, but we can still make progress on this issue in spite of it.
        Hide
        Mark Miller added a comment -

        +1, patch looks good!

        it won't actually kick in until after the first reopen.

        I think we may want to just ditch our lazy creation of the indexwriter and create it upfront. I don't think it saves too much to not create it.

        Show
        Mark Miller added a comment - +1, patch looks good! it won't actually kick in until after the first reopen. I think we may want to just ditch our lazy creation of the indexwriter and create it upfront. I don't think it saves too much to not create it.
        Hide
        Michael McCandless added a comment -

        +1, I like SimpleMergedSegmentWarmer. Maybe we should put that class in lucene core? It seems generically useful and most users won't know the APIs to enum fields / touch the data structures...

        Show
        Michael McCandless added a comment - +1, I like SimpleMergedSegmentWarmer. Maybe we should put that class in lucene core? It seems generically useful and most users won't know the APIs to enum fields / touch the data structures...
        Hide
        Robert Muir added a comment -

        updated patch. I also put this guy in the test rotation.

        Show
        Robert Muir added a comment - updated patch. I also put this guy in the test rotation.
        Hide
        Michael McCandless added a comment -

        +1, looks great! Thanks Rob.

        Show
        Michael McCandless added a comment - +1, looks great! Thanks Rob.
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] rmuir
        http://svn.apache.org/viewvc?view=revision&revision=1476026

        SOLR-4761: add option to plug in mergedSegmentWarmer

        Show
        Commit Tag Bot added a comment - [trunk commit] rmuir http://svn.apache.org/viewvc?view=revision&revision=1476026 SOLR-4761 : add option to plug in mergedSegmentWarmer
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] rmuir
        http://svn.apache.org/viewvc?view=revision&revision=1476030

        SOLR-4761: add option to plug in mergedSegmentWarmer

        Show
        Commit Tag Bot added a comment - [branch_4x commit] rmuir http://svn.apache.org/viewvc?view=revision&revision=1476030 SOLR-4761 : add option to plug in mergedSegmentWarmer
        Hide
        Steve Rowe added a comment -

        Bulk close resolved 4.4 issues

        Show
        Steve Rowe added a comment - Bulk close resolved 4.4 issues
        Hide
        Markus Jelsma added a comment -

        This option reduces latency but is not enabled by default. Is there any reason not to enable it (by default)?
        Thanks

        Show
        Markus Jelsma added a comment - This option reduces latency but is not enabled by default. Is there any reason not to enable it (by default)? Thanks

          People

          • Assignee:
            Unassigned
            Reporter:
            Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development