Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.2
    • Fix Version/s: 4.4, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      Cleanup to Velocity templates shipped under solr/example/solr/collection1/conf/velocity

      • Add README.txt file with complete file list
      • Add comments to all files
      • Add indenting where feasible, fixed indenting in other places. I don't believe I've broken anything that required precise indenting.
      • Make file naming consistent. We had this_that, thisThat and this-that
        Changed all to this_that, though also considered this-that.
      • Modularize some files
      • Included a hit_plain.vm example, though not active by default.
      • Rewrote city/lon/lat selector to work from a hash, though doesn't change the behavior.
      • CSS changes, primarily to make top "tabs" actually look like Tabs (primitive CSS, but at least conveys the idea)

      As far as I know this doesn't change any behavior of the system, nor does it fix any existing bugs. Although I might do bug fixing in a later patch, I wanted to keep this as a pure "code readability" patch.

      1. SOLR-4759.patch
        93 kB
        Mark Bennett
      2. velocity-SOLR-4759.zip
        81 kB
        Mark Bennett

        Activity

        Hide
        Mark Bennett added a comment -

        Patch against TRUNK

        See also recent SOLR-4702

        Show
        Mark Bennett added a comment - Patch against TRUNK See also recent SOLR-4702
        Hide
        Mark Bennett added a comment -

        Because the patch includes both file renaming and content changes the patch command gives errors. Per Erik H, this is a binary version of the changes. (includes .svn dirs). Meant to be extracted from solr/example/solr/collection1/conf/

        Show
        Mark Bennett added a comment - Because the patch includes both file renaming and content changes the patch command gives errors. Per Erik H, this is a binary version of the changes. (includes .svn dirs). Meant to be extracted from solr/example/solr/collection1/conf/
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] ehatcher
        http://svn.apache.org/viewvc?view=revision&revision=1476857

        SOLR-4759: Velocity template cleanup

        Show
        Commit Tag Bot added a comment - [branch_4x commit] ehatcher http://svn.apache.org/viewvc?view=revision&revision=1476857 SOLR-4759 : Velocity template cleanup
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] ehatcher
        http://svn.apache.org/viewvc?view=revision&revision=1476858

        SOLR-4759: Velocity template cleanup

        Show
        Commit Tag Bot added a comment - [trunk commit] ehatcher http://svn.apache.org/viewvc?view=revision&revision=1476858 SOLR-4759 : Velocity template cleanup
        Hide
        Erik Hatcher added a comment -

        Committed to both 4x and trunk. There were a couple of differences in Mark's patch and what I committed with a couple of typo/spelling corrections, updated README, and left the JQuery file names as-is rather than rename them to stay with the same names that of those 3rd party files.

        Show
        Erik Hatcher added a comment - Committed to both 4x and trunk. There were a couple of differences in Mark's patch and what I committed with a couple of typo/spelling corrections, updated README, and left the JQuery file names as-is rather than rename them to stay with the same names that of those 3rd party files.
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] uschindler
        http://svn.apache.org/viewvc?view=revision&revision=1476907

        SOLR-4759: Add missing svn:eol-style properties

        Show
        Commit Tag Bot added a comment - [trunk commit] uschindler http://svn.apache.org/viewvc?view=revision&revision=1476907 SOLR-4759 : Add missing svn:eol-style properties
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] uschindler
        http://svn.apache.org/viewvc?view=revision&revision=1476908

        Merged revision(s) 1476907 from lucene/dev/trunk:
        SOLR-4759: Add missing svn:eol-style properties

        Show
        Commit Tag Bot added a comment - [branch_4x commit] uschindler http://svn.apache.org/viewvc?view=revision&revision=1476908 Merged revision(s) 1476907 from lucene/dev/trunk: SOLR-4759 : Add missing svn:eol-style properties
        Hide
        Steve Rowe added a comment -

        Bulk close resolved 4.4 issues

        Show
        Steve Rowe added a comment - Bulk close resolved 4.4 issues

          People

          • Assignee:
            Erik Hatcher
            Reporter:
            Mark Bennett
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development