Solr
  1. Solr
  2. SOLR-4688

add tests related to reporting core init failures and lazy loaded cores

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.5, 5.0
    • Component/s: None
    • Labels:
      None

      Description

      Spin off of SOLR-4672 zince Erick said he would worry about this so i don't have to...

      we should have more tests that sanity check the behvaior of lazy loaded cores, and reporting back core init failures – both as part of CoreAdmin "STATUS" requests and in the error message returned when trying to use these cores.

      1. SOLR-4688.patch
        15 kB
        Erick Erickson
      2. SOLR-4688.patch
        19 kB
        Erick Erickson

        Activity

        Hide
        Hoss Man added a comment -

        CoreContainerCoreInitFailuresTest and CoreAdminHandlerTest should be a good inspiration for what we want to sanity check about lazy loaded cores.

        a logic flow path i wonder about specifically...

        1) does attempting to lazy load a core that has an init failure (ie: bad config) result in a 500 error being returned and does the init failure get recorded so that it is included in core admin STATUS requests?
        2) does subsequently fixing the problem (ie: fix the bad config) cause future core admin STATUS requests to no longer report that previous init failure?

        Show
        Hoss Man added a comment - CoreContainerCoreInitFailuresTest and CoreAdminHandlerTest should be a good inspiration for what we want to sanity check about lazy loaded cores. a logic flow path i wonder about specifically... 1) does attempting to lazy load a core that has an init failure (ie: bad config) result in a 500 error being returned and does the init failure get recorded so that it is included in core admin STATUS requests? 2) does subsequently fixing the problem (ie: fix the bad config) cause future core admin STATUS requests to no longer report that previous init failure?
        Hide
        Erick Erickson added a comment -

        I changed some error messages a bit to make it easier to find the offending config file.

        I still have to run through all the tests to insure that the changed messages don't mess up other tests. If that all works I'll commit this tomorrow after I give it another once-over.

        Show
        Erick Erickson added a comment - I changed some error messages a bit to make it easier to find the offending config file. I still have to run through all the tests to insure that the changed messages don't mess up other tests. If that all works I'll commit this tomorrow after I give it another once-over.
        Hide
        Erick Erickson added a comment -

        Final patch, I cleaned up the tests a bit and will commit shortly assuming the precommit Im running succeeds

        Show
        Erick Erickson added a comment - Final patch, I cleaned up the tests a bit and will commit shortly assuming the precommit Im running succeeds
        Hide
        ASF subversion and git services added a comment -

        Commit 1519180 from Erick Erickson in branch 'dev/trunk'
        [ https://svn.apache.org/r1519180 ]

        SOLR-4688, add tests related to reporting ore init failures and lazy loaded cores

        Show
        ASF subversion and git services added a comment - Commit 1519180 from Erick Erickson in branch 'dev/trunk' [ https://svn.apache.org/r1519180 ] SOLR-4688 , add tests related to reporting ore init failures and lazy loaded cores
        Hide
        ASF subversion and git services added a comment -

        Commit 1519182 from Erick Erickson in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1519182 ]

        SOLR-4688, add tests related to reporting ore init failures and lazy loaded cores

        Show
        ASF subversion and git services added a comment - Commit 1519182 from Erick Erickson in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1519182 ] SOLR-4688 , add tests related to reporting ore init failures and lazy loaded cores
        Hide
        Adrien Grand added a comment -

        4.5 release -> bulk close

        Show
        Adrien Grand added a comment - 4.5 release -> bulk close

          People

          • Assignee:
            Erick Erickson
            Reporter:
            Hoss Man
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development