Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-4682

CoreAdminRequest.mergeIndexes can not merge mutilple cores.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 4.2
    • Fix Version/s: 4.3, 6.0
    • Component/s: clients - java
    • Labels:
    • Environment:

      java version "1.6.0_20"

      Description

      The mergeIndexes method in CoreAdminRequest class accepts an array of srcCores, but it only merge the last core of array into targetCore. Related code as follows,

      CoreAdminRequest.java
      if (srcCores != null) {
      	for (String srcCore : srcCores) {
      		params.set(CoreAdminParams.SRC_CORE, srcCore);
      	}
      }
      

      The for-each loop above overrides the SRC_CORE value in params and only the last one reserved when loop ends.
      We should remove the for-each loop and set SRC_CORE value with an array of srcCores.
      The code above is in CoreAdminRequest class line 330

        Attachments

        1. SOLR-4682.patch
          3 kB
          Shalin Shekhar Mangar

          Activity

            People

            • Assignee:
              shalinmangar Shalin Shekhar Mangar
              Reporter:
              jason.d.cao Jason.D.Cao
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 1h
                1h
                Remaining:
                Remaining Estimate - 1h
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified