Solr
  1. Solr
  2. SOLR-4651

Remove -excl-slf4j build targets from trunk

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.3, 6.0
    • Fix Version/s: 4.3, 6.0
    • Component/s: Build
    • Labels:
      None

      Description

      SOLR-3706 removes the need for the dist-excl-slf4j and dist-war-excl-slf4j targets in build.xml. In the interests of not breaking user automation on the current major version, they should only be removed from trunk, not branch_4x.

      1. SOLR-4651.patch
        1 kB
        Shawn Heisey

        Issue Links

          Activity

          Hide
          Shawn Heisey added a comment -

          A closer look at the source code reveals that SOLR-3706 has already eliminated the dist-war-excl-slf4j target, perhaps this issue would be OK to apply to both 4x and trunk?

          Show
          Shawn Heisey added a comment - A closer look at the source code reveals that SOLR-3706 has already eliminated the dist-war-excl-slf4j target, perhaps this issue would be OK to apply to both 4x and trunk?
          Hide
          Mark Miller added a comment -

          Ah, I think Ryan must have got it.

          Yeah, I think it's fine to remove in both. Let's just put a warning in CHANGES in the upgrading section.

          Show
          Mark Miller added a comment - Ah, I think Ryan must have got it. Yeah, I think it's fine to remove in both. Let's just put a warning in CHANGES in the upgrading section.
          Hide
          Shawn Heisey added a comment -

          Patch for both 4x and trunk. I will commit shortly if this looks good.

          Show
          Shawn Heisey added a comment - Patch for both 4x and trunk. I will commit shortly if this looks good.
          Hide
          Steve Rowe added a comment -

          Shawn Heisey, you have a stray </target> tag after the ones you removed, and as a result this is non-well-formed XML (xmllint no likey).

          +1 once fixed.

          Also, you should include your name in the CHANGES.txt entry.

          Show
          Steve Rowe added a comment - Shawn Heisey , you have a stray </target> tag after the ones you removed, and as a result this is non-well-formed XML (xmllint no likey). +1 once fixed. Also, you should include your name in the CHANGES.txt entry.
          Hide
          Mark Miller added a comment -

          Also, you should include your name in the CHANGES.txt entry.

          Ignoring what the future should be, in the past, names have not gone in the upgrading section. ie this would go in "other" with shawns name and then the warning would go in the upgrading section nameless.

          Show
          Mark Miller added a comment - Also, you should include your name in the CHANGES.txt entry. Ignoring what the future should be, in the past, names have not gone in the upgrading section. ie this would go in "other" with shawns name and then the warning would go in the upgrading section nameless.
          Hide
          Steve Rowe added a comment -

          in the past, names have not gone in the upgrading section

          Ok, makes sense. I see I have a violating entry in there now with my name - I'll remove it.

          Show
          Steve Rowe added a comment - in the past, names have not gone in the upgrading section Ok, makes sense. I see I have a violating entry in there now with my name - I'll remove it.
          Hide
          Shawn Heisey added a comment -

          Thanks for catching that xml mistake. I'm running tests, then I will run precommit, and if those look good, I'll commit.

          Show
          Shawn Heisey added a comment - Thanks for catching that xml mistake. I'm running tests, then I will run precommit, and if those look good, I'll commit.
          Hide
          Uwe Schindler added a comment -

          Closed after release.

          Show
          Uwe Schindler added a comment - Closed after release.

            People

            • Assignee:
              Shawn Heisey
              Reporter:
              Shawn Heisey
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development