Solr
  1. Solr
  2. SOLR-4624

CachingDirectoryFactory does not need to support forceNew any longer and it may be causing a missing close directory bug.

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.2.1, 4.3, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      Our forceNew uses were essentially hacks that have been replaced with correct solutions. We should remove it.

        Activity

        Hide
        Mark Miller added a comment -

        I'm probably going to put a 'nueter forceNew' back port in 4.2.1 that doesn't change any apis, just doesn't do force a new directory. With the other changes in 4.2.1, this is fine to do.

        Show
        Mark Miller added a comment - I'm probably going to put a 'nueter forceNew' back port in 4.2.1 that doesn't change any apis, just doesn't do force a new directory. With the other changes in 4.2.1, this is fine to do.
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Mark Robert Miller
        http://svn.apache.org/viewvc?view=revision&revision=1459565

        SOLR-4624: CachingDirectoryFactory does not need to support forceNew any longer and it appears to be causing a missing close directory bug. forceNew is no longer respected and will be removed in 4.3.

        Show
        Commit Tag Bot added a comment - [trunk commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1459565 SOLR-4624 : CachingDirectoryFactory does not need to support forceNew any longer and it appears to be causing a missing close directory bug. forceNew is no longer respected and will be removed in 4.3.
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Mark Robert Miller
        http://svn.apache.org/viewvc?view=revision&revision=1459567

        SOLR-4624: CachingDirectoryFactory does not need to support forceNew any longer and it appears to be causing a missing close directory bug. forceNew is no longer respected and will be removed in 4.3.

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1459567 SOLR-4624 : CachingDirectoryFactory does not need to support forceNew any longer and it appears to be causing a missing close directory bug. forceNew is no longer respected and will be removed in 4.3.
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Mark Robert Miller
        http://svn.apache.org/viewvc?view=revision&revision=1459571

        SOLR-4624: remove leftover forceNew params.

        SOLR-4626: getIndexWriter(null) should also respect pauseWriter.

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1459571 SOLR-4624 : remove leftover forceNew params. SOLR-4626 : getIndexWriter(null) should also respect pauseWriter.
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Mark Robert Miller
        http://svn.apache.org/viewvc?view=revision&revision=1459570

        SOLR-4624: remove leftover forceNew params.

        SOLR-4626: getIndexWriter(null) should also respect pauseWriter.

        Show
        Commit Tag Bot added a comment - [trunk commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1459570 SOLR-4624 : remove leftover forceNew params. SOLR-4626 : getIndexWriter(null) should also respect pauseWriter.
        Hide
        Uwe Schindler added a comment -

        Closed after release.

        Show
        Uwe Schindler added a comment - Closed after release.

          People

          • Assignee:
            Mark Miller
            Reporter:
            Mark Miller
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development