Solr
  1. Solr
  2. SOLR-4597

CachingDirectoryFactory#remove should not attempt to empty/remove the index right away but flag for removal after close.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.2.1, 4.3, 5.0
    • Component/s: None
    • Labels:
      None

      Activity

      Hide
      Mark Miller added a comment -

      Previously, we tried to dance around this and do a remove from client code after the directory was released. This is error prone and fragile and fairly ugly semantics for the API.

      Show
      Mark Miller added a comment - Previously, we tried to dance around this and do a remove from client code after the directory was released. This is error prone and fragile and fairly ugly semantics for the API.
      Hide
      Commit Tag Bot added a comment -

      [trunk commit] Mark Robert Miller
      http://svn.apache.org/viewvc?view=revision&revision=1457494

      SOLR-4597: CachingDirectoryFactory#remove should not attempt to empty/remove the index right away but flag for removal after close.

      Show
      Commit Tag Bot added a comment - [trunk commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1457494 SOLR-4597 : CachingDirectoryFactory#remove should not attempt to empty/remove the index right away but flag for removal after close.
      Hide
      Commit Tag Bot added a comment -

      [branch_4x commit] Mark Robert Miller
      http://svn.apache.org/viewvc?view=revision&revision=1457502

      SOLR-4597: CachingDirectoryFactory#remove should not attempt to empty/remove the index right away but flag for removal after close.

      Show
      Commit Tag Bot added a comment - [branch_4x commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1457502 SOLR-4597 : CachingDirectoryFactory#remove should not attempt to empty/remove the index right away but flag for removal after close.
      Hide
      Commit Tag Bot added a comment -

      [trunk commit] Mark Robert Miller
      http://svn.apache.org/viewvc?view=revision&revision=1457556

      SOLR-4597: Additional work.

      SOLR-4598: The Core Admin unload command's option 'deleteDataDir', should use the DirectoryFactory API to remove the data dir.

      SOLR-4599: CachingDirectoryFactory calls close(Directory) on forceNew if the Directory has a refCnt of 0, but it should call closeDirectory(CacheValueValue).

      Show
      Commit Tag Bot added a comment - [trunk commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1457556 SOLR-4597 : Additional work. SOLR-4598 : The Core Admin unload command's option 'deleteDataDir', should use the DirectoryFactory API to remove the data dir. SOLR-4599 : CachingDirectoryFactory calls close(Directory) on forceNew if the Directory has a refCnt of 0, but it should call closeDirectory(CacheValueValue).
      Hide
      Commit Tag Bot added a comment -

      [branch_4x commit] Mark Robert Miller
      http://svn.apache.org/viewvc?view=revision&revision=1457561

      SOLR-4597: Additional work.

      SOLR-4598: The Core Admin unload command's option 'deleteDataDir', should use the DirectoryFactory API to remove the data dir.

      SOLR-4599: CachingDirectoryFactory calls close(Directory) on forceNew if the Directory has a refCnt of 0, but it should call closeDirectory(CacheValueValue).

      Show
      Commit Tag Bot added a comment - [branch_4x commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1457561 SOLR-4597 : Additional work. SOLR-4598 : The Core Admin unload command's option 'deleteDataDir', should use the DirectoryFactory API to remove the data dir. SOLR-4599 : CachingDirectoryFactory calls close(Directory) on forceNew if the Directory has a refCnt of 0, but it should call closeDirectory(CacheValueValue).
      Hide
      Mark Miller added a comment -

      Need to deal with a Windows problem here still.

      Show
      Mark Miller added a comment - Need to deal with a Windows problem here still.
      Hide
      Commit Tag Bot added a comment -

      [trunk commit] Mark Robert Miller
      http://svn.apache.org/viewvc?view=revision&revision=1457816

      SOLR-4597: Because of Windows, we have to wait to delete the data dir after the SolrCore is closed.

      Show
      Commit Tag Bot added a comment - [trunk commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1457816 SOLR-4597 : Because of Windows, we have to wait to delete the data dir after the SolrCore is closed.
      Hide
      Commit Tag Bot added a comment -

      [branch_4x commit] Mark Robert Miller
      http://svn.apache.org/viewvc?view=revision&revision=1457831

      SOLR-4597: Because of Windows, we have to wait to delete the data dir after the SolrCore is closed.

      Show
      Commit Tag Bot added a comment - [branch_4x commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1457831 SOLR-4597 : Because of Windows, we have to wait to delete the data dir after the SolrCore is closed.
      Hide
      Commit Tag Bot added a comment -

      [branch_4x commit] Mark Robert Miller
      http://svn.apache.org/viewvc?view=revision&revision=1458143

      SOLR-4597: Move CHANGES entry.
      SOLR-4598: Move CHANGES entry.
      SOLR-4599: Move CHANGES entry.

      Show
      Commit Tag Bot added a comment - [branch_4x commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1458143 SOLR-4597 : Move CHANGES entry. SOLR-4598 : Move CHANGES entry. SOLR-4599 : Move CHANGES entry.
      Hide
      Commit Tag Bot added a comment -

      [trunk commit] Mark Robert Miller
      http://svn.apache.org/viewvc?view=revision&revision=1458144

      SOLR-4597: Move CHANGES entry.
      SOLR-4598: Move CHANGES entry.
      SOLR-4599: Move CHANGES entry.

      Show
      Commit Tag Bot added a comment - [trunk commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1458144 SOLR-4597 : Move CHANGES entry. SOLR-4598 : Move CHANGES entry. SOLR-4599 : Move CHANGES entry.
      Hide
      Uwe Schindler added a comment -

      Closed after release.

      Show
      Uwe Schindler added a comment - Closed after release.

        People

        • Assignee:
          Mark Miller
          Reporter:
          Mark Miller
        • Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development