Solr
  1. Solr
  2. SOLR-4521

Consider not using 'force' replications in SolrCloud recovery.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.2, 6.0
    • Component/s: SolrCloud
    • Labels:
      None

      Description

      Now that replication has some better tests and bugs fixed, we may be able to stop forcing a replication on every replication call and let the snap pull determine if one is actually needed. This never worked quite right in the past, so I got around it by forcing a replication on recovery whether it was needed or not - the peer sync phase made this not the biggest deal. However, there are cases where it would still be useful - see SOLR-4519.

        Issue Links

          Activity

          Hide
          Mark Miller added a comment -

          I just tried this out and the cloud tests do actually pass now (had SOLR-4511 applied).

          Show
          Mark Miller added a comment - I just tried this out and the cloud tests do actually pass now (had SOLR-4511 applied).
          Hide
          Mark Miller added a comment -

          So I'm going to flip this switch. It's looking good to me, and if there is still a problem it digs up, that's got to be a replication bug we want to find.

          Show
          Mark Miller added a comment - So I'm going to flip this switch. It's looking good to me, and if there is still a problem it digs up, that's got to be a replication bug we want to find.
          Hide
          Commit Tag Bot added a comment -

          [branch_4x commit] Mark Robert Miller
          http://svn.apache.org/viewvc?view=revision&revision=1451663

          SOLR-4521: Stop using the 'force' option for recovery replication. This will keep some less common unnecessary replications from happening.

          Show
          Commit Tag Bot added a comment - [branch_4x commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1451663 SOLR-4521 : Stop using the 'force' option for recovery replication. This will keep some less common unnecessary replications from happening.
          Hide
          Commit Tag Bot added a comment -

          [branch_4x commit] Mark Robert Miller
          http://svn.apache.org/viewvc?view=revision&revision=1451661

          SOLR-4521: Stop using the 'force' option for recovery replication. This will keep some less common unnecessary replications from happening.

          Show
          Commit Tag Bot added a comment - [branch_4x commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1451661 SOLR-4521 : Stop using the 'force' option for recovery replication. This will keep some less common unnecessary replications from happening.
          Hide
          Commit Tag Bot added a comment -

          [trunk commit] Mark Robert Miller
          http://svn.apache.org/viewvc?view=revision&revision=1451660

          SOLR-4521: Stop using the 'force' option for recovery replication. This will keep some less common unnecessary replications from happening.

          Show
          Commit Tag Bot added a comment - [trunk commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1451660 SOLR-4521 : Stop using the 'force' option for recovery replication. This will keep some less common unnecessary replications from happening.
          Hide
          Uwe Schindler added a comment -

          Closed after release.

          Show
          Uwe Schindler added a comment - Closed after release.

            People

            • Assignee:
              Mark Miller
              Reporter:
              Mark Miller
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development