Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-4514

Need tests for OpenExchangeRatesOrgProvider

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.2
    • Component/s: None
    • Labels:
      None

      Description

      the schema.xml used by CurrencyFieldTest declares a fieldType named "openexchangeratesorg_currency" using OpenExchangeRatesOrgProvider pointed at a local copy of open-exchange-rates.json, but field type is completley unused, so nothing about this provider's behavior is ever really tested.

      We should change the test such that all of the functionality tested against the "amount" field is also tested against some new field using this OER provider based fieldType, where the copied data (and static exchange rates) are identical.

      (esasiest way would probably be to introduce a test variable for the field name and let a new subclass override it)

        Attachments

        1. SOLR-4514.patch
          31 kB
          Chris M. Hostetter
        2. SOLR-4514.patch
          33 kB
          Chris M. Hostetter

          Activity

            People

            • Assignee:
              hossman Chris M. Hostetter
              Reporter:
              hossman Chris M. Hostetter
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: