Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-4490

add support for multivalued docvalues

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.2, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      exposing LUCENE-4765 essentially.

      I think we don't need any new options, it just means doing the right thing when someone has docValues=true and multivalued=true.

      1. SOLR-4490.patch
        77 kB
        Robert Muir
      2. SOLR-4490.patch
        74 kB
        Robert Muir

        Issue Links

          Activity

          Hide
          rcmuir Robert Muir added a comment -

          Dumping my current state: queries and faceting are working but I haven't tackled Stats yet.

          The current faceting "fc" code works for the single valued DV case, but i broke it out into a different implementation to handle multiple values and walk per-segment to avoid the binary search in MultiDocValues.

          Show
          rcmuir Robert Muir added a comment - Dumping my current state: queries and faceting are working but I haven't tackled Stats yet. The current faceting "fc" code works for the single valued DV case, but i broke it out into a different implementation to handle multiple values and walk per-segment to avoid the binary search in MultiDocValues.
          Hide
          rcmuir Robert Muir added a comment -

          Updated patch: I think its ready.

          I decided to bail on stats as this has larger issues (I'll open an issue) beyond docvalues. Actually it doesnt work right for multivalued fields at all now anyway.

          Show
          rcmuir Robert Muir added a comment - Updated patch: I think its ready. I decided to bail on stats as this has larger issues (I'll open an issue) beyond docvalues. Actually it doesnt work right for multivalued fields at all now anyway.
          Hide
          jpountz Adrien Grand added a comment -

          +1

          Show
          jpountz Adrien Grand added a comment - +1
          Hide
          commit-tag-bot Commit Tag Bot added a comment -

          [trunk commit] Robert Muir
          http://svn.apache.org/viewvc?view=revision&revision=1450239

          SOLR-4490: multi-valued dv support

          Show
          commit-tag-bot Commit Tag Bot added a comment - [trunk commit] Robert Muir http://svn.apache.org/viewvc?view=revision&revision=1450239 SOLR-4490 : multi-valued dv support
          Hide
          dsmiley David Smiley added a comment -

          Is there a reason why DocValuesFacets, which is a per-segment algorithm, is activated under the facet.method=fc logic instead of 'fcs', since that final 's' means per-segment?

          Show
          dsmiley David Smiley added a comment - Is there a reason why DocValuesFacets, which is a per-segment algorithm, is activated under the facet.method=fc logic instead of 'fcs', since that final 's' means per-segment?
          Hide
          rcmuir Robert Muir added a comment -

          Because its not truly per-segment. It describes this in the header of its javadoc.

          Show
          rcmuir Robert Muir added a comment - Because its not truly per-segment. It describes this in the header of its javadoc.
          Hide
          commit-tag-bot Commit Tag Bot added a comment -

          [branch_4x commit] Robert Muir
          http://svn.apache.org/viewvc?view=revision&revision=1450264

          SOLR-4490: multi-valued dv support

          Show
          commit-tag-bot Commit Tag Bot added a comment - [branch_4x commit] Robert Muir http://svn.apache.org/viewvc?view=revision&revision=1450264 SOLR-4490 : multi-valued dv support
          Hide
          thetaphi Uwe Schindler added a comment -

          Closed after release.

          Show
          thetaphi Uwe Schindler added a comment - Closed after release.

            People

            • Assignee:
              Unassigned
              Reporter:
              rcmuir Robert Muir
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development