Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 1.3
-
Fix Version/s: 1.3
-
Component/s: None
-
Labels:None
Description
ResponseWriters should be able to write SolrDocuments the same way they write Documents. This will be useful for SOLR-303 or other RequestHandlres that modify a SolrDocument and return the result.
Issue Links
- is part of
-
SOLR-303
Distributed Search over HTTP
-
- Closed
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
looks good on a quick scan, go for it!
sorry, i just noticed something ... in commit r610156 the new "writeDoc(String name, SolrDocument doc, Set<String> returnFields, boolean includeScore)" methods all seem to be ignoring the "returnFields" param completely.
doesn't that mean any handler using SolrDocument's won't respect the "fl" param?
good catch Hoss!
Looking at it again, the 'score' bit is weird too – you would get duplicate 'score' fields if you chained this (i think)
if (includeScore) {
writeVal("score", doc.getFirstValue("score"));
}
perhaps it should be:
Index: src/java/org/apache/solr/request/XMLWriter.java
===================================================================
--- src/java/org/apache/solr/request/XMLWriter.java (revision 610424)
+++ src/java/org/apache/solr/request/XMLWriter.java (working copy)
@@ -342,11 +342,14 @@
startTag("doc", name, false);
incLevel();
- if (includeScore) {
- writeVal("score", doc.getFirstValue("score"));
+ if (includeScore && returnFields != null ) {
+ returnFields.add( "score" );
}
for (String fname : doc.getFieldNames()) {
+ if (returnFields!=null && !returnFields.contains(fname)) {
+ continue;
+ }
Object val = doc.getFieldValue(fname);
if (val instanceof Collection) {
code extracted from
SOLR-303and added a small interface to reuse some code