Solr
  1. Solr
  2. SOLR-445

Update Handlers abort with bad documents

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 1.3
    • Fix Version/s: 4.9, 5.0
    • Component/s: update
    • Labels:
      None

      Description

      Has anyone run into the problem of handling bad documents / failures mid batch. Ie:

      <add>
      <doc>
      <field name="id">1</field>
      </doc>
      <doc>
      <field name="id">2</field>
      <field name="myDateField">I_AM_A_BAD_DATE</field>
      </doc>
      <doc>
      <field name="id">3</field>
      </doc>
      </add>

      Right now solr adds the first doc and then aborts. It would seem like it should either fail the entire batch or log a message/return a code and then continue on to add doc 3. Option 1 would seem to be much harder to accomplish and possibly require more memory while Option 2 would require more information to come back from the API. I'm about to dig into this but I thought I'd ask to see if anyone had any suggestions, thoughts or comments.

      1. SOLR-445.patch
        42 kB
        Erick Erickson
      2. solr-445.xml
        0.7 kB
        Erick Erickson
      3. SOLR-445.patch
        18 kB
        Erick Erickson
      4. SOLR-445-3_x.patch
        20 kB
        Erick Erickson
      5. SOLR-445.patch
        45 kB
        Erick Erickson
      6. SOLR-445_3x.patch
        46 kB
        Erick Erickson
      7. SOLR-445.patch
        44 kB
        Erick Erickson
      8. SOLR-445-alternative.patch
        23 kB
        Tomás Fernández Löbbe
      9. SOLR-445-alternative.patch
        23 kB
        Tomás Fernández Löbbe
      10. SOLR-445-alternative.patch
        26 kB
        Tomás Fernández Löbbe

        Issue Links

          Activity

          Will Johnson created issue -
          Grant Ingersoll made changes -
          Field Original Value New Value
          Assignee Grant Ingersoll [ gsingers ]
          Shalin Shekhar Mangar made changes -
          Fix Version/s 1.4 [ 12313351 ]
          Shalin Shekhar Mangar made changes -
          Fix Version/s 1.4 [ 12313351 ]
          Fix Version/s 1.5 [ 12313566 ]
          Grant Ingersoll made changes -
          Assignee Grant Ingersoll [ gsingers ]
          Hoss Man made changes -
          Fix Version/s Next [ 12315093 ]
          Fix Version/s 1.5 [ 12313566 ]
          Erick Erickson made changes -
          Assignee Erick Erickson [ erickerickson ]
          Erick Erickson made changes -
          Attachment SOLR-445.patch [ 12468218 ]
          Attachment solr-445.xml [ 12468219 ]
          Erick Erickson made changes -
          Attachment SOLR-445.patch [ 12468643 ]
          Attachment SOLR-445-3_x.patch [ 12468644 ]
          Erick Erickson made changes -
          Attachment SOLR-445.patch [ 12469113 ]
          Attachment SOLR-445_3x.patch [ 12469114 ]
          Grant Ingersoll made changes -
          Assignee Erick Erickson [ erickerickson ] Grant Ingersoll [ gsingers ]
          Erick Erickson made changes -
          Attachment SOLR-445.patch [ 12476579 ]
          Grant Ingersoll made changes -
          Summary XmlUpdateRequestHandler bad documents mid batch aborts rest of batch Update Handlers abort with bad documents
          Hoss Man made changes -
          Fix Version/s 3.2 [ 12316172 ]
          Fix Version/s Next [ 12315093 ]
          Grant Ingersoll made changes -
          Assignee Grant Ingersoll [ gsingers ]
          Erick Erickson made changes -
          Assignee Erick Erickson [ erickerickson ]
          Robert Muir made changes -
          Fix Version/s 3.3 [ 12316471 ]
          Fix Version/s 3.2 [ 12316172 ]
          Robert Muir made changes -
          Fix Version/s 3.4 [ 12316683 ]
          Fix Version/s 4.0 [ 12314992 ]
          Fix Version/s 3.3 [ 12316471 ]
          Robert Muir made changes -
          Fix Version/s 3.5 [ 12317876 ]
          Fix Version/s 3.4 [ 12316683 ]
          Simon Willnauer made changes -
          Fix Version/s 3.6 [ 12319065 ]
          Fix Version/s 3.5 [ 12317876 ]
          Erick Erickson made changes -
          Fix Version/s 3.6 [ 12319065 ]
          Erick Erickson made changes -
          Issue Type Bug [ 1 ] Improvement [ 4 ]
          Assignee Erick Erickson [ erickerickson ]
          Robert Muir made changes -
          Fix Version/s 4.1 [ 12321141 ]
          Fix Version/s 4.0 [ 12314992 ]
          Per Steffensen made changes -
          Link This issue is part of SOLR-3382 [ SOLR-3382 ]
          Per Steffensen made changes -
          Link This issue depends on SOLR-3382 [ SOLR-3382 ]
          Per Steffensen made changes -
          Link This issue depends on SOLR-3382 [ SOLR-3382 ]
          Erick Erickson made changes -
          Link This issue is related to SOLR-1113 [ SOLR-1113 ]
          Erick Erickson made changes -
          Link This issue is related to SOLR-3178 [ SOLR-3178 ]
          Mark Miller made changes -
          Fix Version/s 4.2 [ 12323893 ]
          Fix Version/s 5.0 [ 12321664 ]
          Fix Version/s 4.1 [ 12321141 ]
          Robert Muir made changes -
          Fix Version/s 4.3 [ 12324128 ]
          Fix Version/s 5.0 [ 12321664 ]
          Fix Version/s 4.2 [ 12323893 ]
          Uwe Schindler made changes -
          Fix Version/s 4.4 [ 12324324 ]
          Fix Version/s 4.3 [ 12324128 ]
          Steve Rowe made changes -
          Fix Version/s 5.0 [ 12321664 ]
          Fix Version/s 4.5 [ 12324743 ]
          Fix Version/s 4.4 [ 12324324 ]
          Adrien Grand made changes -
          Fix Version/s 4.6 [ 12325000 ]
          Fix Version/s 5.0 [ 12321664 ]
          Fix Version/s 4.5 [ 12324743 ]
          Uwe Schindler made changes -
          Fix Version/s 4.7 [ 12325573 ]
          Fix Version/s 4.6 [ 12325000 ]
          David Smiley made changes -
          Fix Version/s 4.8 [ 12326254 ]
          Fix Version/s 4.7 [ 12325573 ]
          Tomás Fernández Löbbe made changes -
          Attachment SOLR-445-alternative.patch [ 12637960 ]
          Tomás Fernández Löbbe made changes -
          Attachment SOLR-445-alternative.patch [ 12638311 ]
          Uwe Schindler made changes -
          Fix Version/s 4.9 [ 12326731 ]
          Fix Version/s 5.0 [ 12321664 ]
          Fix Version/s 4.8 [ 12326254 ]
          Tomás Fernández Löbbe made changes -
          Attachment SOLR-445-alternative.patch [ 12640892 ]

            People

            • Assignee:
              Unassigned
              Reporter:
              Will Johnson
            • Votes:
              3 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

              • Created:
                Updated:

                Development