Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-4353

rename solr/example/contexts/solr.xml to reduce "solr.xml" confusion

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.2, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      I've occasionally seen people get confused about editing the "example solr.xml file" because in addition to the "real" solr.xml file for configuring solr, they also find the jetty context file which is named "solr.xml"

      Unlike tomcat, where the context descriptor file name determines the webapp path, jetty doesn't care what the file name is – it just globs up all the context files and looks at the "contextPath" properties on the WebAppContext objects in those files.

        Activity

        Hide
        hossman Hoss Man added a comment -

        Posting a patch for this seems kind of silly, the change i'm proposing is simply...

        hossman@frisbee:~/lucene/dev$ svn mv solr/example/contexts/solr.xml solr/example/contexts/solr-jetty-context.xml
        A         solr/example/contexts/solr-jetty-context.xml
        D         solr/example/contexts/solr.xml
        
        Show
        hossman Hoss Man added a comment - Posting a patch for this seems kind of silly, the change i'm proposing is simply... hossman@frisbee:~/lucene/dev$ svn mv solr/example/contexts/solr.xml solr/example/contexts/solr-jetty-context.xml A solr/example/contexts/solr-jetty-context.xml D solr/example/contexts/solr.xml
        Hide
        markrmiller@gmail.com Mark Miller added a comment -

        +1, seems fine.

        Show
        markrmiller@gmail.com Mark Miller added a comment - +1, seems fine.
        Hide
        hossman Hoss Man added a comment -

        Committed revision 1438283.
        Committed revision 1438284.

        Show
        hossman Hoss Man added a comment - Committed revision 1438283. Committed revision 1438284.
        Hide
        commit-tag-bot Commit Tag Bot added a comment -

        [trunk commit] Chris M. Hostetter
        http://svn.apache.org/viewvc?view=revision&revision=1438283

        SOLR-4353: Renamed example jetty context file to reduce confusion

        Show
        commit-tag-bot Commit Tag Bot added a comment - [trunk commit] Chris M. Hostetter http://svn.apache.org/viewvc?view=revision&revision=1438283 SOLR-4353 : Renamed example jetty context file to reduce confusion
        Hide
        commit-tag-bot Commit Tag Bot added a comment -

        [branch_4x commit] Chris M. Hostetter
        http://svn.apache.org/viewvc?view=revision&revision=1438284

        SOLR-4353: Renamed example jetty context file to reduce confusion (merge r1438283)

        Show
        commit-tag-bot Commit Tag Bot added a comment - [branch_4x commit] Chris M. Hostetter http://svn.apache.org/viewvc?view=revision&revision=1438284 SOLR-4353 : Renamed example jetty context file to reduce confusion (merge r1438283)
        Hide
        thetaphi Uwe Schindler added a comment -

        Closed after release.

        Show
        thetaphi Uwe Schindler added a comment - Closed after release.

          People

          • Assignee:
            hossman Hoss Man
            Reporter:
            hossman Hoss Man
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development