Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-4330

group.sort is ignored when using truncate and ex/tag local params

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.6, 4.0, 4.1, 6.0
    • Fix Version/s: 3.6.3, 4.2, 6.0
    • Component/s: search
    • Labels:
      None

      Description

      In parseParams method of SimpleFacets, as group sort is not set after creating grouping object, member variable groupSort is always null. Because of it, AbstractAllGroupHeadsCollector with default sort (new Sort()) is created all the time.

      public AbstractAllGroupHeadsCollector<?> createAllGroupCollector() throws IOException {
        Sort sortWithinGroup = groupSort != null ? groupSort : new Sort();
        return TermAllGroupHeadsCollector.create(groupBy, sortWithinGroup);
      }
      
      1. SOLR-4330.patch
        3 kB
        Koji Sekiguchi
      2. SOLR-4330.patch
        0.8 kB
        Koji Sekiguchi

        Activity

        Hide
        koji Koji Sekiguchi added a comment -

        I added a test case which will be failed if the patch is not applied.

        Show
        koji Koji Sekiguchi added a comment - I added a test case which will be failed if the patch is not applied.
        Hide
        commit-tag-bot Commit Tag Bot added a comment -

        [trunk commit] Koji Sekiguchi
        http://svn.apache.org/viewvc?view=revision&revision=1436837

        SOLR-4330: group.sort is ignored when using group.truncate and ex/tag local params together

        Show
        commit-tag-bot Commit Tag Bot added a comment - [trunk commit] Koji Sekiguchi http://svn.apache.org/viewvc?view=revision&revision=1436837 SOLR-4330 : group.sort is ignored when using group.truncate and ex/tag local params together
        Hide
        commit-tag-bot Commit Tag Bot added a comment -

        [branch_4x commit] Koji Sekiguchi
        http://svn.apache.org/viewvc?view=revision&revision=1436839

        SOLR-4330: group.sort is ignored when using group.truncate and ex/tag local params together

        Show
        commit-tag-bot Commit Tag Bot added a comment - [branch_4x commit] Koji Sekiguchi http://svn.apache.org/viewvc?view=revision&revision=1436839 SOLR-4330 : group.sort is ignored when using group.truncate and ex/tag local params together
        Hide
        thetaphi Uwe Schindler added a comment -

        Closed after release.

        Show
        thetaphi Uwe Schindler added a comment - Closed after release.

          People

          • Assignee:
            koji Koji Sekiguchi
            Reporter:
            koji Koji Sekiguchi
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development