Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.3
    • Fix Version/s: 1.3
    • Component/s: clients - java
    • Labels:
      None

      Description

      SolrJ should support sending a request that interacts with the SpellCheckComponent from SOLR-572 and handling the results in a sane manner so users of SolrJ can make use of the SpellCheckComponent code without parsing XML themselves.

      1. SOLR-430.patch
        5 kB
        Shalin Shekhar Mangar
      2. SOLR-430.patch
        10 kB
        Shalin Shekhar Mangar

        Issue Links

          Activity

          Uwe Schindler made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Shalin Shekhar Mangar made changes -
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Resolved [ 5 ]
          Hide
          Shalin Shekhar Mangar added a comment -

          Committed revision 687102.

          Show
          Shalin Shekhar Mangar added a comment - Committed revision 687102.
          Shalin Shekhar Mangar made changes -
          Fix Version/s 1.3 [ 12312486 ]
          Assignee Shalin Shekhar Mangar [ shalinmangar ]
          Priority Major [ 3 ] Minor [ 4 ]
          Component/s spellchecker [ 12312015 ]
          Shalin Shekhar Mangar made changes -
          Attachment SOLR-430.patch [ 12388518 ]
          Hide
          Shalin Shekhar Mangar added a comment -

          Changes

          1. SpellCheckResponse is in it's own separate source file
          2. Added a Test

          I don't think we need to add any methods to SolrQuery. Users can always use the SolrQuery#set methods to add spell check params.

          I shall commit this shortly.

          Show
          Shalin Shekhar Mangar added a comment - Changes SpellCheckResponse is in it's own separate source file Added a Test I don't think we need to add any methods to SolrQuery. Users can always use the SolrQuery#set methods to add spell check params. I shall commit this shortly.
          Shalin Shekhar Mangar made changes -
          Attachment SOLR-430.patch [ 12388415 ]
          Hide
          Shalin Shekhar Mangar added a comment -

          Changes to QueryResponse to parse SpellCheckComponent's response.

          1. The SpellCheckResponse inner class is probably big enough to deserve a separate source file.
          2. Need to add test cases.
          Show
          Shalin Shekhar Mangar added a comment - Changes to QueryResponse to parse SpellCheckComponent's response. The SpellCheckResponse inner class is probably big enough to deserve a separate source file. Need to add test cases.
          Matthew Runo made changes -
          Link This issue relates to SOLR-572 [ SOLR-572 ]
          Matthew Runo made changes -
          Description SolrJ should support at a minimum a basic SpellcheckRequest and Response.

          Response should return a set of strings, the suggestions returned by the SpellcheckQueryHandler.

          Request should accept the basic commands that SC accepts over HTTP.
          SolrJ should support sending a request that interacts with the SpellCheckComponent from SOLR-572 and handling the results in a sane manner so users of SolrJ can make use of the SpellCheckComponent code without parsing XML themselves.
          Hide
          Matthew Runo added a comment -

          Changed issue summary to reflect new code for the spellchecker in solr/lucene.

          Show
          Matthew Runo added a comment - Changed issue summary to reflect new code for the spellchecker in solr/lucene.
          Hide
          Shalin Shekhar Mangar added a comment -

          Matthew – Can you update the issue description? I'll try to add a patch soon.

          Show
          Shalin Shekhar Mangar added a comment - Matthew – Can you update the issue description? I'll try to add a patch soon.
          Hide
          Matthew Runo added a comment -

          Seems like a very reasonable thing to do to me

          Show
          Matthew Runo added a comment - Seems like a very reasonable thing to do to me
          Hide
          Shalin Shekhar Mangar added a comment -

          Should we re-use this issue to implement support for SpellCheckComponent (SOLR-572) instead of the older SpellCheckerRequestHandler?

          Show
          Shalin Shekhar Mangar added a comment - Should we re-use this issue to implement support for SpellCheckComponent ( SOLR-572 ) instead of the older SpellCheckerRequestHandler?
          Mike Klaas made changes -
          Fix Version/s 1.3 [ 12312486 ]
          Matthew Runo made changes -
          Field Original Value New Value
          Component/s spellchecker [ 12312015 ]
          Matthew Runo created issue -

            People

            • Assignee:
              Shalin Shekhar Mangar
              Reporter:
              Matthew Runo
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development